Error-Handler: Ignore errors if the browser is outdated. Fixes #644 #1154
Conversation
datenanfragen/website
|
||||||||||||||||||||||||||||
| Project |
datenanfragen/website
|
| Branch Review |
m_deprecated_error
|
| Run status |
|
| Run duration | 03m 32s |
| Commit |
|
| Committer | Malte |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
8
|
Skipped
|
0
|
Passing
|
80
|
| View all changes introduced in this branch ↗︎ | |
|
Thanks! But my concern is that we should only prevent users with unsupported browsers from reporting errors, not from seeing them. That would only lead to the site being inexplicably broken for them. My suggestion would be to still show the modal but not the sections for reporting the error but instead display a warning that this is likely caused by an outdated browser. |
But we are doing the same with extension users. Should we change the behaviour there as well? But I don't think we really want to support debugging weird extensions.. |
|
The extension errors usually are meaningless for us (they only occur in the extensions' content scripts) and don't affect our site which continues to work fine. That's not the case here, though. If the user's browser doesn't support the functions you check for, features on our site will break. If we don't show any notice to the user, the site will just be inexplicably broken for them. We should tell them that the error was caused by their outdated browser and that they need to switch to a supported browser to use our site. |
- Check for "modern" browser by using JS 2022 feature `[].findLast` - Issue and mailto URL are now optional - make the primitive modal more flexible - JSDoc to help the IDE, since TS-ifying is out-of-scope for this PR
No description provided.