Skip to content
This repository was archived by the owner on Sep 13, 2021. It is now read-only.

Bump chart core to v.8.15.1 #201

Closed
wants to merge 1 commit into from
Closed

Bump chart core to v.8.15.1 #201

wants to merge 1 commit into from

Conversation

elanals
Copy link
Contributor

@elanals elanals commented Jul 8, 2020

No description provided.

@elanals elanals requested a review from gka July 8, 2020 15:43
@elanals elanals mentioned this pull request Jul 8, 2020
@sto3psl
Copy link
Contributor

sto3psl commented Jul 9, 2020

The Redis logs are no errors, just log spam I need to get rid of. The actual failing test is this:

#36 src › routes › charts › {id} › assets › User can write chart asset with almost 2MB - src › routes › charts › {id} › assets › User can write chart asset with almost 2MB

      ---
        name: AssertionError
        assertion: is
        values: {"Difference:":"- 2086667\n+ 2086666"}
        at: src/routes/charts/{id}/assets.test.js:38:7
      ---

I wonder if this is a flaky test since it didn't happen in Jakubs PR.

@sto3psl
Copy link
Contributor

sto3psl commented Jul 9, 2020

jep. Rerunning the tests fixed it. Need to keep an eye on this.

@elanals
Copy link
Contributor Author

elanals commented Jul 14, 2020

Closing this because this bump was already merged from a PR that Jakub had made in parallel that I'd missed when creating this.

@elanals elanals closed this Jul 14, 2020
@sto3psl sto3psl deleted the chart-core-v8.15.1 branch July 29, 2020 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants