Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure that backend Sentry SDK requests are proxied as well #715

Merged
merged 4 commits into from
Feb 19, 2025
Merged

feat: ensure that backend Sentry SDK requests are proxied as well #715

merged 4 commits into from
Feb 19, 2025

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Feb 7, 2025 •
edited
Loading

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • The sentry DSN usually contains the "public" URL of the sentry server, i.e. https://sentry.app-internal.datavisyn.io, which is sometimes not accessible due to authentication. Therefore, we allow to proxy the sentry requests to a different URL, i.e. a cluster internal one without authentication. The same is happening for the frontend with the Sentry proxy router.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer added release: patch PR merge results in a new patch version type: bug Something isn't working labels Feb 7, 2025
@puehringer puehringer requested a review from a team as a code owner February 7, 2025 12:12
@puehringer puehringer self-assigned this Feb 7, 2025
@puehringer puehringer force-pushed the mp/sentry_backend_tunnel branch from 05b543d to 2c4e1f5 Compare February 19, 2025 19:09
@puehringer puehringer added release: minor PR merge results in a new minor version type: feature New feature or request and removed release: patch PR merge results in a new patch version type: bug Something isn't working labels Feb 19, 2025
@puehringer puehringer merged commit 5bc5d21 into develop Feb 19, 2025
4 checks passed
@puehringer puehringer deleted the mp/sentry_backend_tunnel branch February 19, 2025 19:12
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Merged
puehringer added a commit that referenced this pull request Feb 19, 2025
@puehringer
Release 16.3.0 (#731)
ea98f3c 
* chore: prepare next dev release

* feat: log plugin version in upon server start (#724)

TODO: template was removed on mobile, add back later

> Discovered 1 plugin(s): [email protected]

* feat: add arbitrary properties to user object, i.e. mapped from the JWT payload (#730)

* feat: add arbitrary properties to user object, i.e. mapped from the JWT payload

* Added properties setting to NoSecurityStore

* feat: ensure that backend Sentry SDK requests are proxied as well (#715)

* feat: ensure that backend Sentry SDK requests are proxied as well

* Add better frontend and backend DSN options

* Prepare release version 16.3.0

---------

Co-authored-by: datavisyn-bot <>
Co-authored-by: Michael Pühringer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@puehringer puehringer

Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@puehringer