SPARKC-712: Update metrics for read and writes via DSV2 #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @ymuzammil for fixing the issue with the read metrics. Fixes SPARKC-712
|
Hi @jacek-lewandowski Sorry for tagging, I was wondering if I could get your review on this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How did the Spark Cassandra Connector Work or Not Work Before this Patch
Metrics are not updated for read and writes performed via DSV2. The values returned are all 0s.
General Design of the patch
InputMetricsUpdater and OutputMetricsUpdater are used in the DSV2 read (including joins and counts) and write paths.
Fixes: SPARKC-712
How Has This Been Tested?
A couple of integration tests were added.
Checklist: