Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][perf] Reduce stickyHash calculations of non-persistent topics in SHARED subscriptions #254

Open
wants to merge 4 commits into
base: 3.1_ds
Choose a base branch
from

Conversation

dlg99
Copy link
Collaborator

@dlg99 dlg99 commented Apr 17, 2024

Motivation

perf optimization

Modifications

do not repeat StickyKeyHash calculations twice

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

NO

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@dlg99 dlg99 changed the title Reduce stickyHash calculations of non-persistent topics [improve] Reduce stickyHash calculations of non-persistent topics Apr 17, 2024
@dlg99 dlg99 changed the title [improve] Reduce stickyHash calculations of non-persistent topics [improve][perf] Reduce stickyHash calculations of non-persistent topics Apr 17, 2024
Copy link
Collaborator

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

great

can you please send the patch upstream ? we will get a review from the community

@eolivelli eolivelli changed the title [improve][perf] Reduce stickyHash calculations of non-persistent topics [improve][perf] Reduce stickyHash calculations of non-persistent topics in SHARED subscriptions Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants