[Bug Fix] Forward response headers so front end can correctly handle content-encoding #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handle content-encoding. Also added a 500 response code when the response doesnt exist
|
Please, merge this :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pulsar REST api returns data that is gzip encoded. The front end needs to see the content-encoding header in order to decode the data. Previously the content-encoding header was not forwarded to the front end and it did not do this which caused it to malfunction. I added some code in the proxy that forwards the api response headers to the front end and now the front end correctly decodes the response data.
I also added another fix that returns error 500 if the proxy encounters an unknown error when trying to make the request. Previously it would crash because it was trying to access the status property that didn't exist.