-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expected values in SingleRestrictionEstimatedRowCountTest #1523
Conversation
#1502 was merged. @djatnieks should I cherry pick it into this PR? |
Yes, I think that sounds good. |
Reduces amount of created tables by creating all needed tables in advance. As the result the test can be placed into single test function. This improves local test execution time from 5.5 seconds down to 1.4 seconds. Reduction in CI from 13 to 5 seconds. Also removes disabling optimizer, which wasn't necessary.
Fixes riptano/cndb#12243 main-5.0 uses different default for memetable SAI structure than 5.0. This commits adjusts the expected row count values. Also removes assert on the total row count, since it varies in this branch for different column types.
9bac9ed
to
f72dc89
Compare
@djatnieks I cherry picked the commit from |
|
❌ Build ds-cassandra-pr-gate/PR-1523 rejected by Butler70 new test failure(s) in 2 builds Found 70 new test failuresShowing only first 15 new test failures
Found 5 known test failures |
Fixes https://github.com/riptano/cndb/issues/12243
main-5.0 uses different default for memetable SAI structure than 5.0. This commits adjusts the expected row count values. Also removes assert on the total row count, since it varies in this branch for different column types.
This PR is likely to conflict with #1502 after the merge when rebased from
main
.Checklist before you submit for review
NoSpamLogger
for log lines that may appear frequently in the logs