Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR-1133: Changes from DSEDB - DO NOT MERGE #53

Draft
wants to merge 24 commits into
base: trunk
Choose a base branch
from

Conversation

jacek-lewandowski
Copy link
Collaborator

No description provided.

jtgrabowski and others added 24 commits February 23, 2022 09:46
If a user has only MODIFY permission on a table and there is a
materialized view built on the same table an insert will fail
with the following error:
Unauthorized: Error from server: code=2100 [Unauthorized]

Only base MODIFY permission is required to update base with MV.

Co-authored-by: Zhao Yang <[email protected]>
(cherry picked from commit 55dad39)
(cherry picked from commit f1e441e)
(cherry picked from commit 4c7c22c)
(cherry picked from commit 68417f7)
(cherry picked from commit b3bd616)
(cherry picked from commit f2c3701)
(cherry picked from commit ba91f9d)
(cherry picked from commit cce73fb)
Port of DB-1511, riptano/apollo-dtest#197

Co-authored-by: Zhao Yang <[email protected]>
(cherry picked from commit c7beefc)
(cherry picked from commit a02abc6)
(cherry picked from commit 387d688)
(cherry picked from commit d219834)
(cherry picked from commit 8c96801)
(cherry picked from commit 8f68014)
(cherry picked from commit c204342)
(cherry picked from commit fea5074)
(cherry picked from commit f4f6f56)
in offline_tools_test.py

(cherry picked from commit c318850)
(cherry picked from commit 14050b8)
(cherry picked from commit c733919)
(cherry picked from commit 33f3e3f)
(cherry picked from commit 3c72c8f)
…mat as specified for the test

Also made a small refactoring of dtest_config.py

(cherry picked from commit 1253168)
(cherry picked from commit 66b7cba)
(cherry picked from commit fb9042e)
The message is expected since bloom filter is not recreated when there is no index.

(cherry picked from commit f7684e4)
(cherry picked from commit 8ebfd4e)
(cherry picked from commit 4bb4236)
(cherry picked from commit 353b1f1)
(cherry picked from commit 1cbc8d5)
(cherry picked from commit ee9b612)
(cherry picked from commit e3e226a)
(cherry picked from commit b527853)
* STAR-254 add tests for geo and date range types

(cherry picked from commit d15a708)
(cherry picked from commit 5bd412f)
(cherry picked from commit 3a6ba36)
(cherry picked from commit 8a10d56)
(cherry picked from commit 30e81dc)
(cherry picked from commit eb3049c)
(cherry picked from commit fe23e0b)
(cherry picked from commit af5e094)
(cherry picked from commit caaa548)
(cherry picked from commit 31b6a86)
Co-authored-by: Robert Stupp <[email protected]>
(cherry picked from commit 33e486a)
(cherry picked from commit 9fbd1b3)
(cherry picked from commit c479ab3)
(cherry picked from commit 6c74210)
…-io too

(cherry picked from commit 033a492)
(cherry picked from commit 72eedea)
(cherry picked from commit cf7be8c)
(cherry picked from commit 4f6d0be)
* STAR-432: Add tests for consistency level options

Co-authored-by: Robert Stupp [email protected]
(cherry picked from commit 21c18c5)
(cherry picked from commit e6ae1bf)
(cherry picked from commit 05b7502)
(cherry picked from commit b694f07)
Co-authored-by: Aleksandr Sorokoumov <[email protected]>
(cherry picked from commit fd2b1c3)
(cherry picked from commit 66e6b72)
(cherry picked from commit 7060130)
* STAR-765: Add tests for cloud connection.

It is not possible without some infrastructre or tooling effort to trully test cloud connection.
Instead added tests focus on proper cqlsh behavior when secure connect bundle is specified:
- proper default consistency level
- debug information
- reading from cqlshrc and parameters
- skipping host / port information

Testing validation is based on error msgs and debug info.

(cherry picked from commit 9f8cba3)
(cherry picked from commit 50bf851)
(cherry picked from commit e83d99a)
(cherry picked from commit a7ef525)
(cherry picked from commit 0905211)
(cherry picked from commit 3d6068a)
(cherry picked from commit ac5f6b4)
The goal of the test is to "exercise the retry and back-off policies".
And test is trying to achieve it by:
- using arbitrary low write timeout
- and loading / exporting / importing / exporting the data
- assuming that retries and back-off will handle it.
Unfortunately it is very sensitive...

Because we need to find a perfect balance for the timeout and req/s, so that:
- timeouts are indeed hit
- and default COPY util not abort after 90s without succ write
- and default COPY will not abort after 12 unsuccessull backoff attempts

This change disables this test because:
- there is no logic in the test that would check if indeed retries and backoff are exercised, so
- it is perfectly possible that when it passes it just passes without any value
- there are special tests for MAXATTEMPTS and for backoff policy

Final note:
mechanism of retries and backoff policy in COPY command could be improved
by providing some backpressure mechanism to slowdown writes rather than
doing retry or backoff exponentital (with random!).
But this would be a new feature and COPY util is not a place we would like to invest.

(cherry picked from commit 897aab7)
(cherry picked from commit 602cf53)
Improve reliability for slow/loaded test systems by using larger client timeout executing query.

(cherry picked from commit 18d05f6)
(cherry picked from commit 0bc8d67)
Cluster stop requests in cleanup_cluster are made with "gently=True" when Jacoco code coverage is enabled to allow the jacoco agent to record results; however, some tests leave nodes in a state where this type of shutdown does not succeed, resulting in the test being marked failed regardless of it's true completion status.

This change will retry these stop requests with "gently=False" so that the test completion status will not be altered due to shutdown not completing.

(cherry picked from commit f6fc3d3)
(cherry picked from commit aff9d6e)
(cherry picked from commit 47b978d)
(cherry picked from commit 4ecc81b)
(cherry picked from commit 7c8489f)
(cherry picked from commit 9196eaa)
…r_size_test (#41)

Co-authored-by: Branimir Lambov <[email protected]>
(cherry picked from commit 7777fa9)
(cherry picked from commit d06d4c6)
In DB-4215 compaction has been separated from repairs and that separation seems to be pulled from DSE along with UCS. Therefore, checking for the repair status depending on whether compaction was run or not is nor relevant any longer.

This commit updates the test_consistent_repair to the version we have in apollo-dtest.

(cherry picked from commit b454087)
@@ -0,0 +1,30 @@
--- a/tools/assertions.py
+++ b/tools/assertions.py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these update-history files meant to be included?

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just wondering about a few extra files that may be unintended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants