Issues/135 enable parallel maven builds #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PostgreSQL container for JUnit database and integration tests is now started via the testcontainers library. PostgreSQL containers and FHIR jetty servers now use random tcp ports. With `mvn install -DforkCount=4 -T2C` maven modules can be build in parallel and multiple test classes executed concurrently. The parameter -T2C results in two threads per CPU core used to build maven modules. With -DforkCount=4 parallel execution of 4 JUnit test classes can be enabled. Note, this means that for database tests, multiple PostgreSQL containers and for integration tests multiple database containers and jetty servers will be running. Removes not needed batch/bash scripts to start PostgreSQL DB for running JUnit tests via IDE. Adds javadoc to BasicFhirWebserviceClient.
wetret
approved these changes
Nov 17, 2023
default from action -> '["workflow_dispatch", "schedule", "merge_group"]'
wetret
reviewed
Nov 27, 2023
| @@ -162,12 +162,13 @@ | |||
| <dependency> | |||
| <groupId>de.hs-heilbronn.mi</groupId> | |||
| <artifactId>crypto-utils</artifactId> | |||
| <!-- Can't update to 4.0.0 as renamed packages in crypto-utils would break existing process plugins --> | |||
There was a problem hiding this comment.
Generally yes, but as long as we want to support API v1 we need to keep crypto-utils 3.8.0 around. At least as part of the process plugins parent class loader. For future versions of the API we should try to minimize dependencies and transitive dependencies.
wetret
approved these changes
Nov 27, 2023
Reverted build workflow back to old single-step config. Removed pull_request trigger from build workflow to suppress duplicate runs. Pull requests from forks should be merged into issues branches before merging into develop if CI run is required. Enabled parallel maven module builds for all workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables parallel maven builds with parallel test execution.
The PostgreSQL container for JUnit database and integration tests is now started via the testcontainers library. PostgreSQL containers and FHIR jetty servers now use random tcp ports.
With
mvn install -DforkCount=4 -T2Cmaven modules can be build in parallel and multiple test classes executed concurrently. The parameter-T2Cresults in two threads per CPU core used to build maven modules. With-DforkCount=4parallel execution of 4 JUnit test classes can be enabled. Note, this means that for database tests, multiple PostgreSQL containers and for integration tests multiple database containers and jetty servers will be running.Removes not needed batch/bash scripts to start PostgreSQL DB for running JUnit tests via IDE.
Adds javadoc to BasicFhirWebserviceClient.
closes #135