Grant-DbaAgPermission - Update Type description #9201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original description is a little bit confusing: Endpoint will modify the DatabaseMirror endpoint type.
wsmelton
reviewed
Jan 7, 2024
wsmelton
changed the title
Thanks for the suggestion. To me, the original phrase, 'The Endpoint will modify the DatabaseMirror endpoint type,' sounds like some DatabaseMirror endpoint type is being modified. It's in fact the DatabaseMirror endpoint type endpoint that is being modified. But I'm not a native English speaker😂 Co-authored-by: Shawn Melton <[email protected]>
|
@0x7FFFFFFFFFFFFFFF not sure if your client is doing this but our default branch on the project is |
wsmelton
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original description is a little bit confusing: Endpoint will modify the DatabaseMirror endpoint type.
Please read -- recent changes to our repo
On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.
PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.
Type of Change
.\tests\manual.pester.ps1)Purpose
Approach
Commands to test
Screenshots
Learning