Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/collate fn #93

Merged
merged 13 commits into from
Dec 19, 2023
Merged

Fix/collate fn #93

merged 13 commits into from
Dec 19, 2023

Conversation

zhu0619
Copy link
Contributor

@zhu0619 zhu0619 commented Dec 6, 2023

Changelogs


Checklist:

  • _Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • _ Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • _Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@zhu0619 zhu0619 requested a review from maclandrol as a code owner December 6, 2023 20:14
@zhu0619 zhu0619 linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link
Member

@maclandrol maclandrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhu0619, please see comments

molfeat/trans/graph/adj.py Show resolved Hide resolved
env.yml Show resolved Hide resolved
molfeat/trans/graph/adj.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@zhu0619
Copy link
Contributor Author

zhu0619 commented Dec 18, 2023

@maclandrol Let me know if it's ok to be merged.

@maclandrol
Copy link
Member

@zhu0619 feel free to merge and release after the CI is green.

@maclandrol maclandrol merged commit 08a9274 into main Dec 19, 2023
3 checks passed
@maclandrol maclandrol deleted the fix/collate_fn branch September 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the collate_fn for PYGGraphTransformer
2 participants