-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/collate fn #93
Merged
Merged
Fix/collate fn #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclandrol
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhu0619, please see comments
maclandrol
reviewed
Dec 6, 2023
@maclandrol Let me know if it's ok to be merged. |
maclandrol
approved these changes
Dec 18, 2023
@zhu0619 feel free to merge and release after the CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
dataset
to PYGGraphTransformer.get_collate_fntorch_geometric
inenv.yml
andpyproject.toml
Checklist:
Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.feature
,fix
ortest
(or ask a maintainer to do it for you).discussion related to that PR