Update main from develop #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
datalogics-aarroyo
commented
Mar 18, 2024
datalogics-aarroyo
commented
- Add new QRCode sample
Add QRCode sample.
datalogics-aarroyo
added
the
merge at public release
datalogics-robl
approved these changes
Mar 18, 2024
Add initial workflow
- Let's add the list of sample directories to the workflow file. - Added steps for checking out code, modifying PATH to include path to msbuild, and build sample solution files using MSBuild. - The reason we need to use MSBuild to build the samples in CI is because we are unable to install Visual Studio on the GitHub Actions runner.
- The samples are targeting .NET Framework 4.7.2, and the windows-latest runner does not support it. Let's change the GitHub runner to windows-2019, which should support .NET Framework 4.
- That way, the msbuild command that builds the sample will be able to detect that the APDFL NuGet .NET Framework package is present on the GitHub runner.
- Some of the samples do not have .sln files, so there were some failures while trying to install NuGet packages. Let's run the nuget restore and msbuild commands with the .csproj files instead. - The WebApplication sample doesn't have a .csproj or .sln file, so we will be unable to run it in CI.
- The Display samples were failing to build because a platform was not specified. Let's try specifying x64 as the platform to get past that error.
- It seems that the DotNETViewer sample is reliant on the DotNETViewerComponent sample in order to build. Let's add some logic to the "Build samples" step, so that when we build the DotNetViewer sample the DotNETViewerComponent sample is also built. - The DotNETViewerComponent sample will also require the necessary NuGet packages to be installed when testing the DotNETViewer sample. Let's add some logic to the "Install NuGet packages" step to install the packages for DotNETViewerComponent when the workflow is testing the DotNETViewer sample.
- The Printing samples actually need access to a printer, and the GitHub runner cannot be connected to one. Let's just disable the Printing samples, so they will not run in CI.
- The Display samples display a GUI for the user to interact with when run. However, the GitHub runner is not capable of displaying the GUI, so the job gets stuck. Let's disable those samples in CI to allow CI to move forward.
- Also, correct a print statement in the ListPaths sample.
- The DocToImages sample was failing to run in CI because it requires some additional command line arguments. Let's add some logic to the "Run samples" step to run the DocToImages sample with th appropriate arguments.
- Add a step that saves the sample directory name as an environment variable, which will be used to name the directory where the sample output will be saved. - Also, list files in a sample directory for more visibility on files that are present.
- When CI goes to artifact the output files produced by the sample run, it can't find them. Let's have the samples dump their output in the sample directory.
…NET-Framework-samples APDFL-5453: Add CI for .NET Framework samples with GitHub Actions
Because Spot Colorants may only be part of Annotation appearances, to do a proper DeviceN rendering of all colorants this needs to be set. Otherwise we collect all the spot colorants including those of Annotation appearances and setup our DeviceN rendering with it....but at the same time we tell PDFL with our render flags "don't consider them", leading to scrambled output.
Fix render flag setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.