Skip to content

Commit

Permalink
chore: don't show by default in jupyterlab launcher
Browse files Browse the repository at this point in the history
  • Loading branch information
echarles committed Mar 2, 2024
1 parent 8abcf8e commit 5382d9a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion schema/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"showInLauncher": {
"title": "Show Datalayer Core in the launcher",
"description": "Show Datalayer Core in the launcher",
"default": true,
"default": false,
"type": "boolean"
}
},
Expand Down
12 changes: 5 additions & 7 deletions src/jupyterlab/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@ namespace CommandIDs {
export const create = 'datalayer:create-datalayer-widget';
}

export const PLUGIN_ID = '@datalayer/core:plugin';

let tracker: WidgetTracker<MainAreaWidget<DatalayerWidget>>;

/**
* Initialization data for the @datalayer/core extension.
*/
const plugin: JupyterFrontEndPlugin<void> = {
id: PLUGIN_ID,
id: '@datalayer/core:plugin',
autoStart: true,
requires: [ICommandPalette],
optional: [ISettingRegistry, ILauncher, ILayoutRestorer],
Expand All @@ -35,7 +33,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
restorer?: ILayoutRestorer,
) => {
tracker.forEach(widget => widget.dispose());
console.log(`${PLUGIN_ID} is deactivated`);
console.log(`${plugin.id} is deactivated`);
},
activate: (
app: JupyterFrontEnd,
Expand Down Expand Up @@ -86,12 +84,12 @@ const plugin: JupyterFrontEndPlugin<void> = {
settingRegistry
.load(plugin.id)
.then(settings => {
console.log(`${PLUGIN_ID} settings loaded:`, settings.composite);
console.log(`${plugin.id} settings loaded:`, settings.composite);
settingsUpdated(settings);
settings.changed.connect(settingsUpdated);
})
.catch(reason => {
console.error(`Failed to load settings for ${PLUGIN_ID}`, reason);
console.error(`Failed to load settings for ${plugin.id}`, reason);
});
}
requestAPI<any>('config')
Expand All @@ -104,7 +102,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
);
}
);
console.log(`JupyterLab plugin ${PLUGIN_ID} is activated.`);
console.log(`JupyterLab plugin ${plugin.id} is activated.`);
}
};

Expand Down
3 changes: 2 additions & 1 deletion src/tabs/jupyterlab/Server.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { PageHeader, UnderlineNav } from '@primer/react/drafts';
import { UnderlineNav } from '@primer/react';
import { PageHeader } from '@primer/react/drafts';
import { PlusIcon, SettingsIcon } from '@datalayer/icons-react';
import { DatalayerProps } from '../../Datalayer';

Expand Down

0 comments on commit 5382d9a

Please sign in to comment.