Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #62

Open
wants to merge 2 commits into
base: update-examples
Choose a base branch
from

Conversation

m-wierzba
Copy link
Contributor

@m-wierzba m-wierzba commented Nov 23, 2024

The previous PR was accidentally merged using push --force. This one continues the work started in the previous one.

This is needed when one works with a clone and wants the clone to have
the special remote readily available.
@mslw
Copy link
Contributor

mslw commented Dec 6, 2024

I looked at the current state and it looks pretty much as I would imagine it. There is very little, if anything, that would be missing from the narrative.

We spoke off the list and it seems that the main thing missing now is the fMRIPreped dataset to be cloned, which would provide a remake target (in general it would be good to have one, so that the tutorial can be completed without having to go through a full fMRIPrep run first). And this is the only reason for the PR being kept in the draft state. Whoever gets to it first can set it up; I am personally stuck with a provisioning problem for prospective execution (#69 - it seems noone else has experienced it before) and will prioritize understanding what happens there.

@m-wierzba m-wierzba marked this pull request as ready for review December 6, 2024 11:44
Copy link
Contributor

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. There are just two comments that should be addressed before merging (remove the instructions to start the remake-remote).

Comment on lines 63 to 69
Add a `datalad-remake` special remote:

```bash
> git annex initremote datalad-remake type=external externaltype=datalad-remake encryption=none allow-untrusted-execution=true
> git annex initremote datalad-remake type=external externaltype=datalad-remake \
encryption=none allow-untrusted-execution=true autoenable=true
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary anymore because datalad make will automatically start remotes

Comment on lines 66 to 71
Add a `datalad-remake` special remote:

```bash
> git annex initremote datalad-remake type=external externaltype=datalad-remake encryption=none allow-untrusted-execution=true
> git annex initremote datalad-remake type=external externaltype=datalad-remake \
encryption=none allow-untrusted-execution=true autoenable=true
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer required (see above)

Comment on lines +73 to +78
If you're working with your own dataset, make sure to configure a `datalad-remake` special remote:

```bash
> git annex initremote datalad-remake type=external externaltype=datalad-remake \
encryption=none allow-untrusted-execution=true autoenable=true
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this section, manual datalad-remake start is not necessary anymore

@christian-monch
Copy link
Contributor

@m-wierzba The current examples will not work because the remote needs a special git configuration to run in untrusted mode. Let's refer to git-documentation on signing and execute everything in trusted mode.

If that seems too complicated: we can do untrusted computation but the user has to add the following key with the value true to his global git configuration (<DATASET-ID> is the id of the dataset on which datalad make is executed):

datalad.make.allow-untrusted-execution.d-<DATASET-ID>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants