-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tweaks and additions to the docs #114
Conversation
DOC: add a tutorial toctree
…ganization in main DL docs DOC: refhandle to cmd overview
- OSF - Outline use cases - clear distinction on what dl-osf can do and what not
DOC: tweaks to authentication, mention env vars
- tweaked installation instructions - brief gist into functionality as a quickstart and tutorial primer
…e to play through use cases
A first draft is done. I would be grateful if others could give this a read. Feel free to push changes to this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! I left a few minor comments.
docs/source/intro.rst
Outdated
This tool does not work for data that is stored in a storage service other than the OSF_, and within the OSF, only OSF storage, no other third party storage, is supported. | ||
Please refer to the list of `special remotes`_ as hosted by the `git-annex`_ website for other storage services and how to use them with DataLad. | ||
Also, be mindful that OSF storage imposes a maximum file size of 5GB. | ||
Individual files larger than 5GB can not be published with this extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR: We could (should?) actually tweak the special remote config to reflect that max filesize and limit chunks in the annex to 5GB or less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed!
.. code-block:: bash | ||
|
||
# inside of a DataLad dataset | ||
$ datalad create-sibling-osf --title best-study-ever -s osf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osf
is the default name, so it could be stripped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, but I feel as if it would be helpful to be verbose here. I fear that else the --to osf
is not as easily identified as a configurable, arbitrary name but as a generic way to refer to "the OSF"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, but I feel as if it would be helpful to be verbose here. I fear that else the --to osf is not as easily identified as a configurable, arbitrary name but as a generic way to refer to "the OSF"
I agree with this 👍
is -s
the shortform? or is there a --long_form_of_s
? If there is a long form, I think it'd be preferable to use here, because short forms are often abbreviations that can interrupt the reading flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, fair points 👍
It comes with several features that enable the following main use cases: | ||
|
||
#. Export existing datasets to the OSF | ||
#. Clone published datasets from the OSF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this possible right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but not on windows #112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could give "usecase 1" a test run
.. code-block:: bash | ||
|
||
# inside of a DataLad dataset | ||
$ datalad create-sibling-osf --title best-study-ever -s osf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, but I feel as if it would be helpful to be verbose here. I fear that else the --to osf is not as easily identified as a configurable, arbitrary name but as a generic way to refer to "the OSF"
I agree with this 👍
is -s
the shortform? or is there a --long_form_of_s
? If there is a long form, I think it'd be preferable to use here, because short forms are often abbreviations that can interrupt the reading flow.
The preview is here: https://datalad--114.org.readthedocs.build/projects/osf/en/114/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a pass through the docs and left my comments :-)
One more comment: Great job!
|
||
.. image:: ../_static/datastore_sibling.png | ||
|
||
This way you can let OSF handle your data and GitHub your code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having read this tutorial, I am not really sure about the benefit of having the dataset published via GitHub as well (i.e., data on OSF, ... can be datalad installed through OSF or GitHub).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, have pushed an improvement. Personally I also don't see much need for the usecase anymore, but it was one of the major usecases in 0.1 and remains generally possible, so why not (keep it) documented :)
you may want to fix this typo as well datalad-osf/datalad_osf/create_sibling_osf.py Lines 147 to 148 in 7b09c60
- will generated
+ will be generated |
Co-authored-by: Stefan Appelhoff <[email protected]>
Co-authored-by: Stefan Appelhoff <[email protected]>
Co-authored-by: Stefan Appelhoff <[email protected]>
thanks all for feedback and suggestions, its all done. I'll merge this in for now, a fix for #116 will need to remove the 5GB file size limitation. I may try to tackle chunking later today. :) |
This aims to document all current functionality, especially that introduced after the merge of #106.
I have only just started to work on the walk-throughs, therefore this is a work in progress. But I'm away from my keyboard for a few hours, and have pushed so that anyone who wants to can already take a look at this or tackle a walk-through.