Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks and additions to the docs #114

Merged
merged 27 commits into from
Jul 16, 2020
Merged

Minor tweaks and additions to the docs #114

merged 27 commits into from
Jul 16, 2020

Conversation

adswa
Copy link
Member

@adswa adswa commented Jul 15, 2020

This aims to document all current functionality, especially that introduced after the merge of #106.

I have only just started to work on the walk-throughs, therefore this is a work in progress. But I'm away from my keyboard for a few hours, and have pushed so that anyone who wants to can already take a look at this or tackle a walk-through.

@adswa adswa changed the title [WIP] Minor tweaks and additions to the docs Minor tweaks and additions to the docs Jul 15, 2020
@adswa
Copy link
Member Author

adswa commented Jul 15, 2020

A first draft is done. I would be grateful if others could give this a read. Feel free to push changes to this branch.
ping @sappelhoff

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! I left a few minor comments.

This tool does not work for data that is stored in a storage service other than the OSF_, and within the OSF, only OSF storage, no other third party storage, is supported.
Please refer to the list of `special remotes`_ as hosted by the `git-annex`_ website for other storage services and how to use them with DataLad.
Also, be mindful that OSF storage imposes a maximum file size of 5GB.
Individual files larger than 5GB can not be published with this extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: We could (should?) actually tweak the special remote config to reflect that max filesize and limit chunks in the annex to 5GB or less.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed!

.. code-block:: bash

# inside of a DataLad dataset
$ datalad create-sibling-osf --title best-study-ever -s osf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osf is the default name, so it could be stripped

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, but I feel as if it would be helpful to be verbose here. I fear that else the --to osf is not as easily identified as a configurable, arbitrary name but as a generic way to refer to "the OSF"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, but I feel as if it would be helpful to be verbose here. I fear that else the --to osf is not as easily identified as a configurable, arbitrary name but as a generic way to refer to "the OSF"

I agree with this 👍

is -s the shortform? or is there a --long_form_of_s? If there is a long form, I think it'd be preferable to use here, because short forms are often abbreviations that can interrupt the reading flow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its -s/--name. I won't defend this decision at all costs, but the cheatsheet also mentions (only) the short form.
image
And in this particular command, its also not easy to relate --title and --name to project versus sibling name. -s is more likely the sibling wherease --name is more ambiguous.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, fair points 👍

@mih mih mentioned this pull request Jul 16, 2020
It comes with several features that enable the following main use cases:

#. Export existing datasets to the OSF
#. Clone published datasets from the OSF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this possible right now?

Copy link
Member

@mih mih Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but not on windows #112

Copy link
Member Author

@adswa adswa Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could give "usecase 1" a test run

.. code-block:: bash

# inside of a DataLad dataset
$ datalad create-sibling-osf --title best-study-ever -s osf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, but I feel as if it would be helpful to be verbose here. I fear that else the --to osf is not as easily identified as a configurable, arbitrary name but as a generic way to refer to "the OSF"

I agree with this 👍

is -s the shortform? or is there a --long_form_of_s? If there is a long form, I think it'd be preferable to use here, because short forms are often abbreviations that can interrupt the reading flow.

@adswa
Copy link
Member Author

adswa commented Jul 16, 2020

Copy link
Contributor

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass through the docs and left my comments :-)

One more comment: Great job!


.. image:: ../_static/datastore_sibling.png

This way you can let OSF handle your data and GitHub your code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having read this tutorial, I am not really sure about the benefit of having the dataset published via GitHub as well (i.e., data on OSF, ... can be datalad installed through OSF or GitHub).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, have pushed an improvement. Personally I also don't see much need for the usecase anymore, but it was one of the major usecases in 0.1 and remains generally possible, so why not (keep it) documented :)

@sappelhoff
Copy link
Contributor

you may want to fix this typo as well

the associated project page. By default a description will
generated based on the mode the sibling is put into.""",

- will generated
+ will be generated

@adswa
Copy link
Member Author

adswa commented Jul 16, 2020

thanks all for feedback and suggestions, its all done. I'll merge this in for now, a fix for #116 will need to remove the 5GB file size limitation. I may try to tackle chunking later today. :)

@adswa adswa merged commit 25988f8 into master Jul 16, 2020
@adswa adswa deleted the doc-overhaul branch July 16, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants