Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RIA store operations from Mac clients #653

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Fix RIA store operations from Mac clients #653

merged 6 commits into from
Apr 17, 2024

Conversation

mih
Copy link
Member

@mih mih commented Apr 17, 2024

Aiming to resolve datalad/datalad#7536

This work requires datalad v1.0.1 or later!

Log:

mih added 3 commits April 17, 2024 07:03
This is not really a problem, except for datalad-core's RIA tooling,
which is tripping hard...
This is essentially an implementation of the reproducer from
datalad/datalad#7536
Analysis and patch are taken more-or-less exactly from
datalad/datalad#7549. Thanks @mslw!

The patch is slightly modified to be more compact, and work by replacing
`SSHRemoteIO.ensure_writeable()` alone.

Fixes datalad/datalad#7536
These have been developed months ago, and fix critical aspects of SSH
execution on windows clients that prevent any RIA functionality to be
working on windows. Given the uncertainty of a datalad-ria release,
I am importing them here.

Each patch is documented in its header.

Hopefully fixes datalad#654
@mih mih changed the title Fix RIA store operations from non-Linux clients Fix RIA store operations from Mac clients Apr 17, 2024
@mih mih marked this pull request as ready for review April 17, 2024 11:30
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 60.95890% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 92.70%. Comparing base (c8ad167) to head (dc779fa).

Files Patch % Lines
datalad_next/patches/ora_remote.py 22.22% 21 Missing ⚠️
datalad_next/patches/sshremoteio.py 76.66% 8 Missing and 6 partials ⚠️
datalad_next/patches/sshconnector.py 40.00% 12 Missing ⚠️
datalad_next/patches/tests/test_ria.py 72.72% 6 Missing ⚠️
datalad_next/patches/ssh_exec.py 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   93.07%   92.70%   -0.38%     
==========================================
  Files         171      176       +5     
  Lines       11973    12141     +168     
  Branches     1806     1825      +19     
==========================================
+ Hits        11144    11255     +111     
- Misses        642      690      +48     
- Partials      187      196       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih
Copy link
Member Author

mih commented Apr 17, 2024

I will merge this now. The SSHRemoteIO related patches will like receive a further consolidation based on the work coming in from #596 and #655

@mih mih merged commit 401af7b into datalad:main Apr 17, 2024
6 of 8 checks passed
@mih mih deleted the bf-7536 branch April 17, 2024 12:47
@mih mih added this to the 1.4 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing to ria store
1 participant