generated from datalad/datalad-extension-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RIA store operations from Mac clients #653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not really a problem, except for datalad-core's RIA tooling, which is tripping hard...
This is essentially an implementation of the reproducer from datalad/datalad#7536
Analysis and patch are taken more-or-less exactly from datalad/datalad#7549. Thanks @mslw! The patch is slightly modified to be more compact, and work by replacing `SSHRemoteIO.ensure_writeable()` alone. Fixes datalad/datalad#7536
These have been developed months ago, and fix critical aspects of SSH execution on windows clients that prevent any RIA functionality to be working on windows. Given the uncertainty of a datalad-ria release, I am importing them here. Each patch is documented in its header. Hopefully fixes datalad#654
See datalad#654 Like require employing datalad#596 to solve properly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 93.07% 92.70% -0.38%
==========================================
Files 171 176 +5
Lines 11973 12141 +168
Branches 1806 1825 +19
==========================================
+ Hits 11144 11255 +111
- Misses 642 690 +48
- Partials 187 196 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to resolve datalad/datalad#7536
This work requires datalad v1.0.1 or later!
Log:
create-sibling-ria
. Added in datalad/datalad-ci-docker-containers@bae2501BaseSSHConnection
datalad-ria#91SSHRemoteIO
shell datalad-ria#90PersistentSubShell
-feature #596 to replace thePopen
call inSSHRemoteIO.__init__
leads to a usable authentication prompt, on windows, with no stdin connected to the terminal. I guess that is the path forward. Wait for AddPersistentSubShell
-feature #596 to land and then patch RIA/ORA to use it.PersistentSubShell
-feature #596