Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh user list after activating a user in admin dashboard #967

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #812

Refresh user list after activating a user in admin dashboard

@BenjaminCharmes BenjaminCharmes self-assigned this Oct 24, 2024
@BenjaminCharmes BenjaminCharmes added the webapp For issues/PRs pertaining to the web interface label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (93b09be) to head (6122daa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files          62       62           
  Lines        3928     3928           
=======================================
  Hits         2686     2686           
  Misses       1242     1242           

Copy link

cypress bot commented Oct 24, 2024

datalab    Run #2631

Run Properties:  status check passed Passed #2631  •  git commit ac39724975 ℹ️: Merge 6122daa189967aafc5ad6f4ee6d85525ac184284 into 93b09bebe4c905ee5d78b7fff813...
Project datalab
Branch Review bc/admin-userlist-refresh
Run status status check passed Passed #2631
Run duration 06m 40s
Commit git commit ac39724975 ℹ️: Merge 6122daa189967aafc5ad6f4ee6d85525ac184284 into 93b09bebe4c905ee5d78b7fff813...
Committer Benjamin Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 24, 2024 10:51
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks @BenjaminCharmes!

@ml-evs ml-evs added bug Something isn't working usability labels Oct 24, 2024
@ml-evs ml-evs merged commit 48e609d into main Oct 24, 2024
24 checks passed
@ml-evs ml-evs deleted the bc/admin-userlist-refresh branch October 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working usability webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin user list does not refresh after activating a user
2 participants