Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (partial) train+eval model template nb #42

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

bdewilde
Copy link
Member

@bdewilde bdewilde commented Dec 21, 2024

changes

  • adds a partial model training+evaluation template notebook for pdp schools, with TODOs marked for where future work is needed
  • fixes a bug in a modeling util function

context

Trying to extend the template school-agnostic pipeline further, from end to end.

questions

Any objections to committing this in partial form, for future dev work?

@bdewilde bdewilde marked this pull request as ready for review December 21, 2024 16:01
Copy link
Contributor

@nm3224 nm3224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@nm3224 nm3224 closed this Dec 23, 2024
@bdewilde
Copy link
Member Author

Hey @nm3224 , thanks for taking a look, but just want to clarify expectations / process around PRs:

  • if you're not tagged as a reviewer (or haven't otherwise been requested), don't feel any obligation to review! in fact, it's probably better to leave it to the reviewers, since they may have context that you don't have.
  • when submitting reviews, please leave the actual merging (or closing) of the PR to the person who submitted it. there may be dependencies between PRs or other cleanup work that they need to take care of first.
  • finally, "closing" a PR doesn't merge, it just sends the code you've reviewed into the dustbin of history.

@bdewilde bdewilde reopened this Dec 23, 2024
@bdewilde bdewilde merged commit 488c442 into develop Dec 23, 2024
10 checks passed
@bdewilde bdewilde deleted the add-train-model-template-nb branch December 23, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants