Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added encapsulating double quotes to comply with DOT language #1176

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Release notes

### Upcoming
- Fixed - Added encapsulating double quotes to comply with [DOT language](https://graphviz.org/doc/info/lang.html) - PR [#1176](https://github.com/datajoint/datajoint-python/pull/1176)

### 0.14.2 -- Aug 19, 2024
- Added - Migrate nosetests to pytest - PR [#1142](https://github.com/datajoint/datajoint-python/pull/1142)
- Added - Codespell GitHub Actions workflow
Expand Down
2 changes: 1 addition & 1 deletion datajoint/diagram.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def _make_graph(self):
)
# relabel nodes to class names
mapping = {
node: lookup_class_name(node, self.context) or node
node: f'"{lookup_class_name(node, self.context) or node}"'
for node in graph.nodes()
}
new_names = [mapping.values()]
Expand Down
4 changes: 2 additions & 2 deletions tests_old/test_erd.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,5 @@ def test_part_table_parsing():
# https://github.com/datajoint/datajoint-python/issues/882
erd = dj.Di(schema)
graph = erd._make_graph()
assert "OutfitLaunch" in graph.nodes()
assert "OutfitLaunch.OutfitPiece" in graph.nodes()
assert '"OutfitLaunch"' in graph.nodes()
assert '"OutfitLaunch.OutfitPiece"' in graph.nodes()