update alpine image | added debian image #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ernaldis
approved these changes
May 17, 2022
guzman-raphael
suggested changes
Aug 29, 2022
There was a problem hiding this comment.
Thanks @yambottle! Have a few remaining questions for this one.
| apk update && \ | ||
| # export functions, for download, json parsing, ssh keygen, api keygen | ||
| apk add --no-cache bash curl jq openssh openssl && \ | ||
| apk add --no-cache bash curl jq openssh openssl util-linux bind-tools && \ |
There was a problem hiding this comment.
I see bind-tools useful for using dig in debugging DNS. What's specifically useful for debugging from util-linux?
| @@ -2,16 +2,15 @@ FROM python:3.8-alpine3.12 as k8s_build | |||
| ARG KOPS_VERSION | |||
| ARG HELM_VERSION | |||
| RUN \ | |||
| mkdir /main && \ | |||
| set -x; > /etc/inittab && mkdir /main && \ | |||
There was a problem hiding this comment.
set -x can be useful to display the actual command that is running. A bit unclear on what is the purpose for removing /etc/inittab though. 🤔
| context: ../.. | ||
| dockerfile: ./dist/alpine/Dockerfile | ||
| args: | ||
| - KOPS_VERSION | ||
| - HELM_VERSION | ||
| image: vathes/k8s-admin:kops${KOPS_VERSION}-helm${HELM_VERSION}-alpine | ||
| command: | ||
| image: registry.vathes.com/vathes/k8s-admin:kops${KOPS_VERSION}-helm${HELM_VERSION}-alpine |
There was a problem hiding this comment.
Since this image is public we published it to Docker Hub. We technically could get away with free storage on this one. 😅
| echo "$$0 running..."; echo "PATH: '$$PATH'"; tail -f /dev/null; |
There was a problem hiding this comment.
Suggested change
| echo "$$0 running..."; echo "PATH: '$$PATH'"; tail -f /dev/null; | |
| - | | |
| echo "$$0 running..." | |
| echo "PATH: '$$PATH'" | |
| tail -f /dev/null |
| build: | ||
| # Uncomment to enable local build | ||
| context: ../.. | ||
| dockerfile: ./dist/alpine/Dockerfile |
There was a problem hiding this comment.
Suggested change
| dockerfile: ./dist/alpine/Dockerfile | |
| dockerfile: ./dist/debian/Dockerfile |
Comment on lines
+11
to
+16
| image: registry.vathes.com/vathes/k8s-admin:kops${KOPS_VERSION}-helm${HELM_VERSION}-debian | ||
| command: | ||
| - bash | ||
| - -c | ||
| - > | ||
| echo "$$0 running..."; echo "PATH: '$$PATH'"; tail -f /dev/null; |
There was a problem hiding this comment.
Suggested change
| image: registry.vathes.com/vathes/k8s-admin:kops${KOPS_VERSION}-helm${HELM_VERSION}-debian | |
| command: | |
| - bash | |
| - -c | |
| - > | |
| echo "$$0 running..."; echo "PATH: '$$PATH'"; tail -f /dev/null; | |
| image: vathes/k8s-admin:kops${KOPS_VERSION}-helm${HELM_VERSION}-debian | |
| command: | |
| - bash | |
| - -c | |
| - | | |
| echo "$$0 running..." | |
| echo "PATH: '$$PATH'" | |
| tail -f /dev/null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.