-
Notifications
You must be signed in to change notification settings - Fork 26
Add assertions public api methods #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
…meters in new code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better. A few wording / readability nitpicks.
Co-authored-by: Adrien Lavoillotte <[email protected]>
As fred T explained
|
Methods are working (no failure, result looks good) on a python3.6 notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nitpicks on formatting docstring, otherwise the API works smoothly :-)
First draft of methods to be added is in the wiki
Can be tested with the dip pr that adds tests for the methods added in this PR.