Skip to content

Add assertions public api methods #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Dec 18, 2020
Merged

Conversation

arnaudde
Copy link

@arnaudde arnaudde commented Dec 2, 2020

First draft of methods to be added is in the wiki
Can be tested with the dip pr that adds tests for the methods added in this PR.

@arnaudde arnaudde added this to the 9.0 milestone Dec 2, 2020
@arnaudde arnaudde self-assigned this Dec 2, 2020
Arnaud dE and others added 7 commits December 4, 2020 14:25
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Co-authored-by: Adrien Lavoillotte <[email protected]>
Copy link
Contributor

@instanceofme instanceofme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. A few wording / readability nitpicks.

Co-authored-by: Adrien Lavoillotte <[email protected]>
@arnaudde
Copy link
Author

arnaudde commented Dec 14, 2020

As fred T explained ~ in class reference are for sphynx syntax display purposes. I am using simple strings without path as everything is in the same package.

https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html
If you prefix the content with ~, the link text will only be the last component of the target. For example, :py:meth:~Queue.Queue.get will refer to Queue.Queue.get but only display get as the link text. This does not work with all cross-reference roles, but is domain specific.

@arnaudde
Copy link
Author

Methods are working (no failure, result looks good) on a python3.6 notebook

Copy link
Contributor

@instanceofme instanceofme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially LGTM

Copy link
Contributor

@nicolasservel nicolasservel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nitpicks on formatting docstring, otherwise the API works smoothly :-)

@arnaudde arnaudde merged commit 20a2bc1 into master Dec 18, 2020
@arnaudde arnaudde deleted the feature/dss90-ml-assertions branch December 18, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants