Skip to content

refactor(web): Embed url mapping into Tabs component for general use #13648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anthonyburdi
Copy link
Contributor

Adds functionality for mapping URLs to tabs to the Tabs component. When navigating tabs, the url changes and vice versa. Also includes changes to storybook.

@anthonyburdi anthonyburdi self-assigned this May 28, 2025
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 28, 2025
Copy link

codecov bot commented May 28, 2025

Bundle Report

Changes will increase total bundle size by 355 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.65MB 355 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 355 bytes 16.02MB 0.0%

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Tabs/Tabs.tsx → Total Size: 2.59kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 28, 2025
Copy link
Collaborator

@purnimagarg1 purnimagarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jun 2, 2025
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@anthonyburdi anthonyburdi merged commit 7d5519f into datahub-project:master Jun 2, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants