-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest): use lossy collections #12523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the TopKDict is really only usable for value types where sorting is a reasonable thing to do. we're using it in a couple spots with string mem_size, which probably won't work properly
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Outdated
Show resolved
Hide resolved
c8edbe3
to
512a2a5
Compare
Need to update the integration tests |
512a2a5
to
0dfd45a
Compare
kafka connect failure is being handled in another PR |
0dfd45a
to
5de7567
Compare
Checklist