Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): use lossy collections #12523

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 31, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gestion/src/datahub/ingestion/source/abs/report.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
...ngestion/source/aws/sagemaker_processors/common.py 97.77% <100.00%> (+0.05%) ⬆️
...ub/ingestion/source/bigquery_v2/bigquery_report.py 100.00% <100.00%> (ø)
.../src/datahub/ingestion/source/delta_lake/report.py 83.33% <100.00%> (ø)
.../src/datahub/ingestion/source/dynamodb/dynamodb.py 80.97% <100.00%> (+0.09%) ⬆️
...ion/src/datahub/ingestion/source/elastic_search.py 56.27% <100.00%> (+0.19%) ⬆️
...datahub/ingestion/source/iceberg/iceberg_common.py 97.43% <100.00%> (+0.02%) ⬆️
...tion/src/datahub/ingestion/source/identity/okta.py 80.43% <100.00%> (+0.07%) ⬆️
...estion/src/datahub/ingestion/source/kafka/kafka.py 94.05% <100.00%> (+0.02%) ⬆️
...c/datahub/ingestion/source/kafka_connect/common.py 99.02% <100.00%> (+<0.01%) ⬆️
...ata-ingestion/src/datahub/ingestion/source/ldap.py 90.78% <100.00%> (+0.04%) ⬆️
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb5191...ed43eb8. Read the comment docs.

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the TopKDict is really only usable for value types where sorting is a reasonable thing to do. we're using it in a couple spots with string mem_size, which probably won't work properly

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 31, 2025
@anshbansal anshbansal force-pushed the ab-2025-jan-31-cleanup-reports branch from c8edbe3 to 512a2a5 Compare February 3, 2025 10:40
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 3, 2025
@anshbansal anshbansal marked this pull request as draft February 3, 2025 12:06
@anshbansal
Copy link
Collaborator Author

Need to update the integration tests

@anshbansal anshbansal force-pushed the ab-2025-jan-31-cleanup-reports branch from 512a2a5 to 0dfd45a Compare February 4, 2025 06:52
@anshbansal anshbansal marked this pull request as ready for review February 4, 2025 06:52
@anshbansal anshbansal added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Feb 4, 2025
@anshbansal
Copy link
Collaborator Author

kafka connect failure is being handled in another PR

@anshbansal anshbansal merged commit d1e8a0a into master Feb 4, 2025
190 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-31-cleanup-reports branch February 4, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants