fix(ingestion/teradata): teradata profiling fix for pooling #12507
+12
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teradata sqlalchemy connector does not support max_overflow. replaced with poolclass=QueuePool.
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hsheth2
reviewed
Jan 31, 2025
| @@ -286,7 +287,7 @@ def grouper(fk_row): | |||
|
|
|||
| # TODO: Check if there's a better way | |||
| fk_dicts = list() | |||
| for constraint_info, constraint_cols in groupby_unsorted(res, grouper): | |||
| for constraint_info, constraint_cols in groupby(res, grouper): | |||
| # replace pooling with pooling for teradata | ||
| if "max_overflow" in self.config.options: | ||
| self.config.options.pop("max_overflow") | ||
| self.config.options["poolclass"] = QueuePool |
There was a problem hiding this comment.
can you add some comments explaining the logic here?
also we have similar logic
that appears to be getting undone - but ideally we never add max_overflow in the first place
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Teradata sqlalchemy connector does not support max_overflow. replaced with poolclass=QueuePool.