Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/dbt-core): support fetching using the s3a protocol #12465

Merged
merged 3 commits into from
Jan 30, 2025
Merged

feat(ingest/dbt-core): support fetching using the s3a protocol #12465

merged 3 commits into from
Jan 30, 2025
+1 −1

Conversation

haon85
Copy link
Contributor

@haon85 haon85 commented Jan 25, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Sorry, something went wrong.

add support to ingest from "s3a" protocol
Loading
Loading status checks…
bd3703a
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 25, 2025
@haon85 haon85 changed the title add support to ingest from "s3a" protocol #12464 add support to ingest from "s3a" protocol Jan 25, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 25, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...stion/src/datahub/ingestion/source/dbt/dbt_core.py 87.40% <100.00%> (ø)

... and 94 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280e82a...a46cb08. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 27, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 28, 2025
@haon85 haon85 requested a review from hsheth2 January 28, 2025 08:44
@haon85
Merge branch 'master' into master
Loading
Loading status checks…
a46cb08
@hsheth2 hsheth2 changed the title add support to ingest from "s3a" protocol feat(ingest/dbt-core): support fetching using the s3a protocol Jan 30, 2025
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Jan 30, 2025
@anshbansal anshbansal merged commit c8e88ae into datahub-project:master Jan 30, 2025
212 of 219 checks passed
@hsheth2 hsheth2 mentioned this pull request Jan 30, 2025
Closed
eagle-25 pushed a commit to eagle-25/datahub that referenced this pull request Feb 12, 2025
@haon85 @eagle-25
feat(ingest/dbt-core): support fetching using the s3a protocol (datah…
3e06d32 
…ub-project#12465)

Co-authored-by: hzhang <[email protected]>
eagle-25 pushed a commit to eagle-25/datahub that referenced this pull request Feb 17, 2025
@haon85 @eagle-25
feat(ingest/dbt-core): support fetching using the s3a protocol (datah…
7544dc4 
…ub-project#12465)

Co-authored-by: hzhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haon85 @hsheth2 @anshbansal