-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add ContainerKey.parent_key method #12423
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, I'm curious, what's the use case? when I would need to generate the parent key for a given key? 🤔
@sgomezvillamor this is setting up some infra for the sdk improvements. Basically if we can infer the parent container, then we can also infer the browse path v2 automatically. That will let us avoid needing the |
This will be useful as we try to make our SDKs easier to use.
Checklist