Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add ContainerKey.parent_key method #12423

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 21, 2025

This will be useful as we try to make our SDKs easier to use.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...adata-ingestion/src/datahub/emitter/mcp_builder.py 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
...adata-ingestion/src/datahub/emitter/mcp_builder.py 98.24% <87.50%> (-0.82%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4d6bc...c4dfcd3. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 22, 2025
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
However, I'm curious, what's the use case? when I would need to generate the parent key for a given key? 🤔

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 22, 2025
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Jan 22, 2025

@sgomezvillamor this is setting up some infra for the sdk improvements. Basically if we can infer the parent container, then we can also infer the browse path v2 automatically. That will let us avoid needing the auto_browse_path_v2 helper for basic sdk usages.

@hsheth2 hsheth2 merged commit aff3fae into master Jan 22, 2025
148 of 151 checks passed
@hsheth2 hsheth2 deleted the container-parent-key branch January 22, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants