-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(GMS): migrate GMS to Spring boot #12389
Open
david-leifker
wants to merge
1
commit into
datahub-project:master
Choose a base branch
from
david-leifker:gms-spring-boot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(GMS): migrate GMS to Spring boot #12389
david-leifker
wants to merge
1
commit into
datahub-project:master
from
david-leifker:gms-spring-boot
+1,626
−899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-leifker
force-pushed
the
gms-spring-boot
branch
from
January 19, 2025 04:26
2a30b07
to
c26b804
Compare
datahub-cyborg
bot
added
the
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
label
Jan 19, 2025
david-leifker
force-pushed
the
gms-spring-boot
branch
from
January 21, 2025 17:45
c26b804
to
a53179b
Compare
david-leifker
force-pushed
the
gms-spring-boot
branch
from
January 21, 2025 22:13
a53179b
to
efc987f
Compare
* GMS: Migrate GMS Spring WebApp -> Spring Boot (embedded jetty 12) * Spring WebMvc endpoints are the default, Rest.li endpoints are secondary * Removed jetty 11 * Refactor kafka consumers startup * GMS with all embedded consumers startup <40s * Neo4j upgraded * Dgraph upgraded
david-leifker
force-pushed
the
gms-spring-boot
branch
from
January 22, 2025 16:45
efc987f
to
ba2bb60
Compare
esteban
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a first pass and changes are reasonable, lets get the PR so we can move forward with any other change that might be necessary. Thanks @david-leifker!
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
labels
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant refactor of GMS into a Spring Boot application instead of a Spring web application running in jetty.
Checklist