-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/glue): Implement unified AWS Glue table representation #12335
Closed
svdimchenko
wants to merge
9
commits into
datahub-project:master
from
svdimchenko:feat/glue-table-representation
Closed
feat(ingestion/glue): Implement unified AWS Glue table representation #12335
svdimchenko
wants to merge
9
commits into
datahub-project:master
from
svdimchenko:feat/glue-table-representation
+151
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
community-contribution
PR or Issue raised by member(s) of DataHub Community
labels
Jan 14, 2025
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
datahub-cyborg
bot
added
the
needs-review
Label for PRs that need review from a maintainer.
label
Jan 14, 2025
svdimchenko
changed the title
feat: Implement unified AWS Glue table representation
feat(ingestion/glue): Implement unified AWS Glue table representation
Jan 15, 2025
closing due to more complex reengineering is required #12410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
ingestion
PR or Issue related to the ingestion of metadata
needs-review
Label for PRs that need review from a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
We are currently using following tech stack:
We want to have the full data lineage, however it's broken on
glue tables -> dbt
stage.Actually glue ingestor ignores athena's catalog name and stores entities in format
database.table
, however actual representation in case whenplatform='athena'
should becatalog.database.table
.As I dig deeper, I understand that currently
catalog
entity is missed forglue
ingest type.So adding
catalog
atdatabase
level anddatabase
at datahub'sschema
level seems logical to me. However this brings breaking changes to the current implementation.WDYT regarding the issue ? Once we finalise the vision, I can improve the current PR.
Checklist