Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion/lookml): resolve access notation for LookML Constant #12277

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

feat(ingestion/lookml): resolve access notation for LookML Constant #12277

wants to merge 22 commits into from
+935 −42

Conversation

sagar-salvi-apptware
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@sagar-salvi-apptware sagar-salvi-apptware changed the title lookml parameter support feat(ingestion/lookml): resolve access notation for LookML parameters Jan 6, 2025
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 6, 2025
@hsheth2 hsheth2 mentioned this pull request Jan 7, 2025
Closed
@sagar-salvi-apptware sagar-salvi-apptware marked this pull request as ready for review January 8, 2025 11:14
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-784-lookml-parameter branch from e6de550 to 4ef052f Compare January 8, 2025 11:18
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-784-lookml-parameter branch from 4ef052f to 4a9ec88 Compare January 8, 2025 11:20
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 8, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 8, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter needs-review Label for PRs that need review from a maintainer. labels Jan 8, 2025
sgomezvillamor
sgomezvillamor reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

My only suggestion would be to refactor the logic in resolve_lookml_parameter into a separate class. Then, the different warning scenarios can be easily unit tested.

@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-784-lookml-parameter branch from 710eff2 to 4e7bc94 Compare January 10, 2025 06:23
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ngestion/source/looker/looker_template_language.py 92.85% 2 Missing ⚠️
...c/datahub/ingestion/source/looker/lookml_source.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
...ahub/ingestion/source/looker/looker_dataclasses.py 84.07% <100.00%> (+0.58%) ⬆️
...ahub/ingestion/source/looker/looker_file_loader.py 80.39% <100.00%> (+0.39%) ⬆️
...c/datahub/ingestion/source/looker/lookml_config.py 93.20% <100.00%> (+0.13%) ⬆️
...c/datahub/ingestion/source/looker/lookml_source.py 80.97% <83.33%> (+1.91%) ⬆️
...ngestion/source/looker/looker_template_language.py 93.95% <92.85%> (+1.71%) ⬆️

... and 31 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3471857...f4fb5d7. Read the comment docs.

@datahub-cyborg datahub-cyborg bot removed the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Jan 10, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 21, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 22, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 22, 2025
mayurinehate
mayurinehate reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting few more minor changes.

Also, can you check why CI is failing ?

metadata-ingestion/tests/integration/lookml/test_lookml.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/integration/lookml/test_lookml.py Outdated Show resolved Hide resolved
metadata-ingestion/docs/sources/looker/lookml_post.md Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 22, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 23, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 23, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 23, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor left review comments

@hsheth2 hsheth2 hsheth2 requested changes

@mayurinehate mayurinehate mayurinehate approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sagar-salvi-apptware @kevinkarchacryl @sgomezvillamor @hsheth2 @mayurinehate @sid-acryl