fix(ci): include docker-postgres-setup job in docker-unified workflow #11633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
Masterchen09
force-pushed
the
fix-ci-docker-postgres-setup
branch
from
ef4215d to
4af1871
Compare
datahub-cyborg
bot
added
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also here: https://datahubspace.slack.com/archives/C02FKQAGRG9/p1727725080514819
Disclaimer: I have absolutely no idea whether this will solve the issue with the datahub-postgres-setup image in the future, I have just copied the logic for the datahub-mysql-setup image and adjusted it for the datahub-postgres-setup image...not sure why there is a separate workflow for building the datahub-postgres-setup image, however it would make sense that it should follow the same logic as the workflow for the datahub-mysql-setup image...
Someone also has to manually tag the datahub-postgres-setup:6a165a8 image with the tag datahub-postgres-setup:v0.14.1, otherwise the (now official, not only pre-release) new release for v0.14.1 will not work for those who are using a PostgreSQL database: https://hub.docker.com/layers/acryldata/datahub-postgres-setup/6a165a8/images/sha256-487aaf113b21d7656996a377a0e21cf8ac6824af282f3e72d580e403b1049ab0?context=explore
FYI @david-leifker
Checklist