Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove default value from DatahubClientConfig.server #11570

Merged
merged 5 commits into from
Oct 16, 2024
Merged

fix(ingest): remove default value from DatahubClientConfig.server #11570

merged 5 commits into from
Oct 16, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 8, 2024 •
edited
Loading

Stacked on #11569

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Oct 8, 2024
@hsheth2 hsheth2 marked this pull request as ready for review October 9, 2024 16:24
@treff7es
Copy link
Contributor

treff7es commented Oct 9, 2024

@hsheth2 tests are failing

@hsheth2 hsheth2 force-pushed the rest-sink-config-server-default branch from 982b41f to fa66e12 Compare October 16, 2024 03:32
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 16, 2024
@hsheth2 hsheth2 merged commit d34717f into master Oct 16, 2024
72 of 73 checks passed
@hsheth2 hsheth2 deleted the rest-sink-config-server-default branch October 16, 2024 20:50
epatotski pushed a commit to acryldata/datahub that referenced this pull request Oct 22, 2024
@hsheth2 @patotskiy
fix(ingest): remove default value from DatahubClientConfig.server (da…
84b5d62 
…tahub-project#11570)
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@hsheth2 @sleeperdeep
fix(ingest): remove default value from DatahubClientConfig.server (da…
1a4080d 
…tahub-project#11570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es