Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new policy #68

Merged
merged 8 commits into from
Mar 14, 2024
Merged

added new policy #68

merged 8 commits into from
Mar 14, 2024

Conversation

VHlushchen
Copy link
Collaborator

No description provided.

@VHlushchen VHlushchen requested a review from dnillovna March 12, 2024 09:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Pusher: @VHlushchen, Action: pull_request, OS: windows-latest, Working Directory: aws, Workflow: Validate

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output 

Success! The configuration is valid.

Pusher: @VHlushchen, Action: pull_request, OS: ubuntu-latest, Working Directory: aws, Workflow: Validate

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Infracost report

💰 Monthly cost will not change

Cost details 
──────────────────────────────────

154 cloud resources were detected:
∙ 44 were estimated, 20 of which include usage-based costs, see https://infracost.io/usage-file
∙ 107 were free, rerun with --show-skipped to see details
∙ 3 are not supported yet, rerun with --show-skipped to see details
This comment will be updated when code changes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output 

Success! The configuration is valid.

Pusher: @VHlushchen, Action: pull_request, OS: macos-latest, Working Directory: aws, Workflow: Validate

dnillovna
dnillovna reviewed Mar 12, 2024
View reviewed changes
aws/ecs.tf Outdated
@@ -1083,7 +1083,8 @@ resource "aws_iam_policy" "grok_spawner" {
{
"Effect" = "Allow",
"Action" : [
"ecs:CreateService"
"ecs:CreateService",
"ecs:TagResource"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check that ecs:TagResource is compatible with conditions and resources.

@VHlushchen VHlushchen requested a review from dnillovna March 13, 2024 11:21
@VHlushchen VHlushchen merged commit ab8f1bb into main Mar 14, 2024
10 of 11 checks passed
@dnillovna dnillovna deleted the vlad-h/GROK-15161-IAM-tags branch July 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnillovna dnillovna dnillovna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VHlushchen @dnillovna