Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noop: code reorganization #24

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Noop: code reorganization #24

merged 1 commit into from
Nov 28, 2023

Conversation

drscholly
Copy link
Contributor

@drscholly drscholly commented Nov 28, 2023 •
edited
Loading

Checklist

  • I have read the Contribution Guide ;
  • I have read the Contributor License Agreement (CLA) and understand that the submission of this PR will constitute an electronic signature of my agreement of the terms and conditions of DataGalaxy's CLA ;
  • There is an approved issue describing the change when contributing a new feature ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

No new functionality, just some code reorganization to be more clear.

Changes proposed in this pull request:

  • Moved DataGalaxyApiGlossary to its own file
  • Moved utils functions to "datagalaxy_api" file
  • Edited imports to avoid breaking changes
  • Rename to "list_properties" for shorter name

@drscholly
noop: API code reorganization
e86345a 
- Moved DataGalaxyApiGlossary to its own file
- Moved utils functions to "datagalaxy_api" file
- Edited imports to avoid breaking changes
- Rename to "list_properties" for shorter name
@drscholly drscholly requested a review from a team as a code owner November 28, 2023 10:07
@ggrossetie ggrossetie merged commit 4f4a04f into datagalaxy-lab:main Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drscholly @ggrossetie