#62 Added cli tool to export data in a csv format #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Apr 18, 2024
src/bin/orc-export.rs
Outdated
| struct Cli { | ||
| /// Path to the orc file | ||
| file: PathBuf, | ||
| /// Output file |
There was a problem hiding this comment.
Maybe need to enhance doc here to indicate it outputs to stdout if not provided?
src/bin/orc-export.rs
Outdated
| let cli = Cli::parse(); | ||
| let f = File::open(&cli.file)?; | ||
| let output_writer: Box<dyn io::Write> = if let Some(output) = cli.output { | ||
| Box::new(File::create(output).unwrap()) |
There was a problem hiding this comment.
Suggested change
| Box::new(File::create(output).unwrap()) | |
| Box::new(File::create(output)?) |
Let's take advantage of the Result return type 👍
src/bin/orc-export.rs
Outdated
| Box::new(io::stdout()) | ||
| }; | ||
|
|
||
| let reader = ArrowReaderBuilder::try_new(f).unwrap().build(); |
There was a problem hiding this comment.
Suggested change
| let reader = ArrowReaderBuilder::try_new(f).unwrap().build(); | |
| let reader = ArrowReaderBuilder::try_new(f)?.build(); |
Ditto
waynexia
pushed a commit
that referenced
this pull request
Oct 24, 2024
* #62 Added cli tool to export data in a csv format * CR fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is quite useful for me. In the futuree I plan to add support for selecting the columns and saving as json