Refactor Integer RLE V2 handling #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Dec 4, 2023
| num_literals: usize, | ||
| used: usize, | ||
| skip_corrupt: bool, | ||
| literals: VecDeque<i64>, |
There was a problem hiding this comment.
VecDeque provides same functionality, without us needing to fiddle with the indices/len ourselves
|
|
||
| impl<R: Read> RleReaderV2<R> { | ||
| pub fn new(reader: R, signed: bool, skip_corrupt: bool) -> Self { | ||
| pub fn new(reader: R, signed: bool) -> Self { |
There was a problem hiding this comment.
I don't think we should provide functionality for skipping corrupt streams:
- If this integer stream is corrupt, and since columns are made of multiple streams, chances are the expected output will also be corrupt as stream lengths won't match
Comment on lines
+54
to
+58
| pub fn read_values(&mut self) -> Result<bool> { | ||
| let header = match try_read_u8(&mut self.reader)? { | ||
| Some(byte) => byte, | ||
| None => return Ok(false), | ||
| }; |
There was a problem hiding this comment.
Removed the ignore_eof logic, as have similar thoughts to the removal of skip corrupt
progval
pushed a commit
to progval/datafusion-orc
that referenced
this pull request
Mar 6, 2024
Implement serialization / deserialization via bytecode
waynexia
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Refactor Integer RLE V2 handling * Fix * Trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.