Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to map datatype #32

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

WenyXu
Copy link
Collaborator

@WenyXu WenyXu commented Nov 9, 2023

related #14

@WenyXu WenyXu requested a review from Jefffrey November 9, 2023 13:47
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #32 (424b021) into main (b78e9da) will increase coverage by 0.77%.
Report is 1 commits behind head on main.
The diff coverage is 79.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   76.44%   77.22%   +0.77%     
==========================================
  Files          32       34       +2     
  Lines        3210     3302      +92     
==========================================
+ Hits         2454     2550      +96     
+ Misses        756      752       -4     

@Jefffrey
Copy link
Collaborator

Jefffrey commented Nov 9, 2023

I will take a look later today (or over weekend) 👍

@Jefffrey
Copy link
Collaborator

I'll hold off on reviewing this further. Need this updated with main and also after #30 is merged, since it seems to duplicate some changes

@WenyXu WenyXu marked this pull request as draft November 11, 2023 04:56
@WenyXu WenyXu marked this pull request as ready for review November 11, 2023 06:03
@WenyXu
Copy link
Collaborator Author

WenyXu commented Nov 11, 2023

@Jefffrey PTAL

@WenyXu WenyXu merged commit c89535a into datafusion-contrib:main Nov 11, 2023
13 checks passed
progval pushed a commit to progval/datafusion-orc that referenced this pull request Mar 6, 2024
waynexia pushed a commit that referenced this pull request Oct 24, 2024
feat: support to map datatype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants