Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Use libcramjam for compression codecs #136

Conversation

milesgranger
Copy link

See if there was any interest in using libcramjam.

There's probably further use/simplification available here, and could anyway help libcramjam's implementation. It's presently used in python's cramjam package that has served quite well.

datafusion-orc could make use of other codecs as well with low overhead that are already part of libcramjam (brotli, bzip2, xz, etc and the ISA-L backed zlib/deflate/gzip algorithms which are quite a bit faster than flate2 w/ zlib-ng [1] (at the expense of more C code and reduced compression level options 0, 1, 3)

I was blissfully unaware there existed a MIT friendly LZO implementation so might add that to libcramjam as well going forward.

[1] https://github.com/milesgranger/isal-rs/tree/main?tab=readme-ov-file#benchmarks

@milesgranger milesgranger marked this pull request as draft October 25, 2024 04:35
@Xuanwo
Copy link
Collaborator

Xuanwo commented Oct 25, 2024

Hi, thank you for bringing this up! As discussed at #120, we are moving to https://github.com/datafusion-contrib/orc-rust to get it ready been accepted into Apache ORC. Would you like to start a PR there instead? Thank you and sorry for any inconvenience.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Oct 25, 2024

Hi, thank you for bringing this up! As discussed at #120, we are moving to https://github.com/datafusion-contrib/orc-rust to get it ready been accepted into Apache ORC. Would you like to start a PR there instead? Thank you and sorry for any inconvenience.

also cc @waynexia, would you like to remove code in this repo and make it clear in README?

@milesgranger
Copy link
Author

Thanks for the heads up, moved now. :)

@milesgranger milesgranger deleted the milesgranger/libcramjam branch October 25, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants