Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read array<float> columns correctly #112

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix: read array<float> columns correctly #112

merged 2 commits into from
Jul 2, 2024

Conversation

youngsofun
Copy link
Contributor

@youngsofun youngsofun commented Jul 2, 2024 •
edited
Loading

fix #111

@youngsofun youngsofun changed the title fix #111: Handle reading array<float> columns correctly fix: Handle reading array<float> columns correctly Jul 2, 2024
@youngsofun youngsofun changed the title fix: Handle reading array<float> columns correctly fix: read array<float> columns correctly Jul 2, 2024
@youngsofun youngsofun mentioned this pull request Jul 2, 2024
Closed
@WenyXu WenyXu requested review from Jefffrey and WenyXu July 2, 2024 12:16
WenyXu
WenyXu approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@WenyXu WenyXu merged commit f819f41 into datafusion-contrib:main Jul 2, 2024
9 checks passed
@Xuanwo
Copy link
Collaborator

Xuanwo commented Jul 2, 2024

Does this should be treated as breaking changes?

@youngsofun
Copy link
Contributor Author

Does this should be treated as breaking changes?

it is not

waynexia pushed a commit that referenced this pull request Oct 24, 2024
@youngsofun
fix: read array<float> columns correctly (#112)
d4c5377 
* fix: panic when read column of type array<float>

* ci: add tests for nested column.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@Jefffrey Jefffrey Awaiting requested review from Jefffrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Fail to read column of type array<float>
3 participants
@youngsofun @Xuanwo @WenyXu