comment our jobs we aren't ready for

datafusion-contrib · Jul 13, 2024 · fd7b4b3 · fd7b4b3
1 parent fb90a64
commit fd7b4b3
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 60 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -59,19 +59,20 @@ jobs:
         with:
           reporter: 'github-pr-check'
           github_token: ${{ secrets.GITHUB_TOKEN }}
-  semver:
-    runs-on: ubuntu-latest
-    name: semver
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          submodules: true
-      - name: Install stable
-        uses: dtolnay/rust-toolchain@stable
-        with:
-          components: rustfmt
-      - name: cargo-semver-checks
-        uses: obi1kenobi/cargo-semver-checks-action@v2
+  # TODO: enable once we release our packages.
+  # semver:
+  #   runs-on: ubuntu-latest
+  #   name: semver
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #       with:
+  #         submodules: true
+  #     - name: Install stable
+  #       uses: dtolnay/rust-toolchain@stable
+  #       with:
+  #         components: rustfmt
+  #     - name: cargo-semver-checks
+  #       uses: obi1kenobi/cargo-semver-checks-action@v2
   doc:
     # run docs generation on nightly rather than stable. This enables features like
     # https://doc.rust-lang.org/beta/unstable-book/language-features/doc-cfg.html which allows an

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -107,50 +107,51 @@ jobs:
         run: cargo generate-lockfile
       - name: cargo test
         run: cargo test --locked --all-features --all-targets
-  coverage:
-    # use llvm-cov to build and collect coverage and outputs in a format that
-    # is compatible with codecov.io
-    #
-    # note that codecov as of v4 requires that CODECOV_TOKEN from
-    #
-    #   https://app.codecov.io/gh/<user or org>/<project>/settings
-    #
-    # is set in two places on your repo:
-    #
-    # - https://github.com/jonhoo/guardian/settings/secrets/actions
-    # - https://github.com/jonhoo/guardian/settings/secrets/dependabot
-    #
-    # (the former is needed for codecov uploads to work with Dependabot PRs)
-    #
-    # PRs coming from forks of your repo will not have access to the token, but
-    # for those, codecov allows uploading coverage reports without a token.
-    # it's all a little weird and inconvenient. see
-    #
-    #   https://github.com/codecov/feedback/issues/112
-    #
-    # for lots of more discussion
-    runs-on: ubuntu-latest
-    name: ubuntu / stable / coverage
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          submodules: true
-      - name: Install stable
-        uses: dtolnay/rust-toolchain@stable
-        with:
-          components: llvm-tools-preview
-      - name: cargo install cargo-llvm-cov
-        uses: taiki-e/install-action@cargo-llvm-cov
-      - name: cargo generate-lockfile
-        if: hashFiles('Cargo.lock') == ''
-        run: cargo generate-lockfile
-      - name: cargo llvm-cov
-        run: cargo llvm-cov --locked --all-features --lcov --output-path lcov.info
-      - name: Record Rust version
-        run: echo "RUST=$(rustc --version)" >> "$GITHUB_ENV"
-      - name: Upload to codecov.io
-        uses: codecov/codecov-action@v4
-        with:
-          fail_ci_if_error: true
-          token: ${{ secrets.CODECOV_TOKEN }}
-          env_vars: OS,RUST
+  # TODO: enable codecov once we have a CODECOV_TOKEN
+  # coverage:
+  #   # use llvm-cov to build and collect coverage and outputs in a format that
+  #   # is compatible with codecov.io
+  #   #
+  #   # note that codecov as of v4 requires that CODECOV_TOKEN from
+  #   #
+  #   #   https://app.codecov.io/gh/<user or org>/<project>/settings
+  #   #
+  #   # is set in two places on your repo:
+  #   #
+  #   # - https://github.com/jonhoo/guardian/settings/secrets/actions
+  #   # - https://github.com/jonhoo/guardian/settings/secrets/dependabot
+  #   #
+  #   # (the former is needed for codecov uploads to work with Dependabot PRs)
+  #   #
+  #   # PRs coming from forks of your repo will not have access to the token, but
+  #   # for those, codecov allows uploading coverage reports without a token.
+  #   # it's all a little weird and inconvenient. see
+  #   #
+  #   #   https://github.com/codecov/feedback/issues/112
+  #   #
+  #   # for lots of more discussion
+  #   runs-on: ubuntu-latest
+  #   name: ubuntu / stable / coverage
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #       with:
+  #         submodules: true
+  #     - name: Install stable
+  #       uses: dtolnay/rust-toolchain@stable
+  #       with:
+  #         components: llvm-tools-preview
+  #     - name: cargo install cargo-llvm-cov
+  #       uses: taiki-e/install-action@cargo-llvm-cov
+  #     - name: cargo generate-lockfile
+  #       if: hashFiles('Cargo.lock') == ''
+  #       run: cargo generate-lockfile
+  #     - name: cargo llvm-cov
+  #       run: cargo llvm-cov --locked --all-features --lcov --output-path lcov.info
+  #     - name: Record Rust version
+  #       run: echo "RUST=$(rustc --version)" >> "$GITHUB_ENV"
+  #     - name: Upload to codecov.io
+  #       uses: codecov/codecov-action@v4
+  #       with:
+  #         fail_ci_if_error: true
+  #         token: ${{ secrets.CODECOV_TOKEN }}
+  #         env_vars: OS,RUST