Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bitterness Categories Based on IBU #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Bitterness Categories Based on IBU #61

wants to merge 3 commits into from

Conversation

williebsweet
Copy link
Contributor

Expand Bitterness from two categories into five categories, based on the IBU ranges below:

Category IBU (>) IBU (<=)
Extra Malty 0 20
Malty 20 40
Well Balanced 40 60
Hoppy 60 80
Extra Hoppy 80

datafold[bot]
datafold bot reviewed May 23, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs of tables modified in this pull request: ⚠️ - 1
INTEGRATION.BEERS.BEERS
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 8 8
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (beer_id)
🔍  Primary-key inferred from tests
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 7 compared) ⚠️
💬 Total differing rows 712 / 2,410 (30%) ⚠️
💬 Total differing values 4.2% ⚠️
View diff details →


Diffs of downstream tables: ✔️ - 1, ⚠️ - 3 No changes to INTEGRATION.BEERS_DEV.sales (details) ✔️

INTEGRATION.BEERS.PROMO_DELIVERIES
main expand-IBU-categorization
💬 Total rows 180 150 (-17%)
Schema diff
💬 Total columns 3 3
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (customer_id)
💬 Distinct PKs 180 150 (-17%)
💬 Exclusive PKs 180 (100%) 150 (100%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 2 compared) ✔️
💬 Total differing rows 0 / 0 (-/-) ✔️
💬 Total differing values -/- ✔️
View diff details →

INTEGRATION.BEERS.ORDER_LINES
main expand-IBU-categorization
💬 Total rows 900 900 (0%)
Schema diff
💬 Total columns 7 7
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 900 900 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 5 compared) ⚠️
💬 Total differing rows 900 / 900 (100%) ⚠️
💬 Total differing values 40% ⚠️
View diff details →

INTEGRATION.BEERS.BEERS_WITH_BREWERIES
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 12 12
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (brewery_id, beer_id, beer_name)
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 9 compared) ⚠️
💬 Total differing rows 712 / 2,410 (30%) ⚠️
💬 Total differing values 3.3% ⚠️
View diff details →


@vvkh vvkh closed this Jul 13, 2022
@vvkh vvkh reopened this Jul 13, 2022
datafold[bot]
datafold bot reviewed Jul 13, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs of tables modified in this pull request: ⚠️ - 4
INTEGRATION.BEERS.ORDERS
main expand-IBU-categorization
💬 Total rows 300 300 (0%)
Schema diff
💬 Total columns 4 5
💬 Mismatched columns 1 2 (0 reorders, 1 type changes) ⚠️
Primary keys diff (order_no)
💬 Distinct PKs 300 300 (0%)
💬 Exclusive PKs 10 (3.3%) 10 (3.3%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 2 compared) ⚠️
💬 Total differing rows 290 / 290 (100%) ⚠️
💬 Total differing values 50% ⚠️
View diff details →

INTEGRATION.BEERS.BEERS
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 7 8
💬 Mismatched columns 1 2 (0 reorders, 1 type changes) ⚠️
Primary keys diff (beer_id)
🔍  Primary-key inferred from tests
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 5 compared) ⚠️
💬 Total differing rows 10 / 2,410 (0.41%) ⚠️
💬 Total differing values 0.083% ⚠️
View diff details →

INTEGRATION.BEERS.SALES
main expand-IBU-categorization
💬 Total rows 810 810 (0%)
Schema diff
💬 Total columns 17 18
💬 Mismatched columns 2 3 (0 reorders, 2 type changes) ⚠️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 810 810 (0%)
💬 Exclusive PKs 27 (3.3%) 27 (3.3%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 13 compared) ✔️
💬 Total differing rows 0 / 783 (0%) ✔️
💬 Total differing values 0% ✔️
View diff details →

INTEGRATION.BEERS.ORDER_LINES
main expand-IBU-categorization
💬 Total rows 900 900 (0%)
Schema diff
💬 Total columns 7 7
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 900 900 (0%)
💬 Exclusive PKs 30 (3.3%) 30 (3.3%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 5 compared) ⚠️
💬 Total differing rows 870 / 870 (100%) ⚠️
💬 Total differing values 40% ⚠️
View diff details →


Diffs of downstream tables: ⚠️ - 2
INTEGRATION.BEERS.PROMO_DELIVERIES
main expand-IBU-categorization
💬 Total rows 180 180 (0%)
Schema diff
💬 Total columns 3 3
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (customer_id)
💬 Distinct PKs 180 180 (0%)
💬 Exclusive PKs 180 (100%) 180 (100%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 2 compared) ✔️
💬 Total differing rows 0 / 0 (-/-) ✔️
💬 Total differing values -/- ✔️
View diff details →

INTEGRATION.BEERS.BEERS_WITH_BREWERIES
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 11 12
💬 Mismatched columns 1 2 (0 reorders, 1 type changes) ⚠️
Primary keys diff (brewery_id, beer_id, beer_name)
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 10 (0.41%) 10 (0.41%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 7 compared) ✔️
💬 Total differing rows 0 / 2,400 (0%) ✔️
💬 Total differing values 0% ✔️
View diff details →


datafold[bot]
datafold bot reviewed Jul 13, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mode downstream: ✔️ - 0
Hightouch downstream: ⚠️ - 5
  • Models
  • Syncs
    • total-beer-sales-to-datafold-notion-68c0k (Total beer sales)
    • total-beer-sales-to-google-sheet-test-fsiq8 (Total beer sales)
    • total-beer-sales-to-google-sheet-test-g7a0q (Total beer sales)

datafold[bot]
datafold bot reviewed Jul 18, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs of tables modified in this pull request: ⚠️ - 4
INTEGRATION.BEERS.ORDERS
main expand-IBU-categorization
💬 Total rows 300 300 (0%)
Schema diff
💬 Total columns 5 5
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no)
💬 Distinct PKs 300 300 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 4 compared) ⚠️
💬 Total differing rows 300 / 300 (100%) ⚠️
💬 Total differing values 50% ⚠️
View diff details →

INTEGRATION.BEERS.BEERS
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 8 8
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (beer_id)
🔍  Primary-key inferred from tests
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 7 compared) ⚠️
💬 Total differing rows 671 / 2,410 (28%) ⚠️
💬 Total differing values 4.0% ⚠️
View diff details →

INTEGRATION.BEERS.ORDER_LINES
main expand-IBU-categorization
💬 Total rows 900 900 (0%)
Schema diff
💬 Total columns 7 7
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 900 900 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 5 compared) ⚠️
💬 Total differing rows 900 / 900 (100%) ⚠️
💬 Total differing values 40% ⚠️
View diff details →

INTEGRATION.BEERS.SALES
main expand-IBU-categorization
💬 Total rows 810 810 (0%)
Schema diff
💬 Total columns 18 18
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 810 810 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 16 compared) ⚠️
💬 Total differing rows 150 / 810 (19%) ⚠️
💬 Total differing values 1.2% ⚠️
View diff details →


Diffs of downstream tables: ⚠️ - 2
INTEGRATION.BEERS.BEERS_WITH_BREWERIES
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 12 12
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (brewery_id, beer_id, beer_name)
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 9 compared) ⚠️
💬 Total differing rows 671 / 2,410 (28%) ⚠️
💬 Total differing values 3.1% ⚠️
View diff details →

INTEGRATION.BEERS.PROMO_DELIVERIES
main expand-IBU-categorization
💬 Total rows 180 180 (0%)
Schema diff
💬 Total columns 3 3
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (customer_id)
💬 Distinct PKs 180 180 (0%)
💬 Exclusive PKs 180 (100%) 180 (100%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 2 compared) ✔️
💬 Total differing rows 0 / 0 (-/-) ✔️
💬 Total differing values -/- ✔️
View diff details →


datafold[bot]
datafold bot reviewed Jul 18, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mode downstream: ✔️ - 0
Hightouch downstream: ⚠️ - 6

@alexandermorozov alexandermorozov force-pushed the expand-IBU-categorization branch from c24c582 to ddfc07d Compare July 25, 2022 10:55
datafold[bot]
datafold bot reviewed Jul 25, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs of tables modified in this pull request: ⚠️ - 4
INTEGRATION.BEERS.SALES
main expand-IBU-categorization
💬 Total rows 810 810 (0%)
Schema diff
💬 Total columns 18 18
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 810 810 (0%)
💬 Exclusive PKs 27 (3.3%) 27 (3.3%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 16 compared) ⚠️
💬 Total differing rows 145 / 783 (19%) ⚠️
💬 Total differing values 1.2% ⚠️
View diff details →

INTEGRATION.BEERS.ORDER_LINES
main expand-IBU-categorization
💬 Total rows 900 900 (0%)
Schema diff
💬 Total columns 7 7
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no, order_line)
💬 Distinct PKs 900 900 (0%)
💬 Exclusive PKs 30 (3.3%) 30 (3.3%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 5 compared) ⚠️
💬 Total differing rows 870 / 870 (100%) ⚠️
💬 Total differing values 40% ⚠️
View diff details →

INTEGRATION.BEERS.BEERS
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 8 8
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (beer_id)
🔍  Primary-key inferred from tests
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 7 compared) ⚠️
💬 Total differing rows 671 / 2,410 (28%) ⚠️
💬 Total differing values 4.0% ⚠️
View diff details →

INTEGRATION.BEERS.ORDERS
main expand-IBU-categorization
💬 Total rows 300 300 (0%)
Schema diff
💬 Total columns 5 5
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (order_no)
💬 Distinct PKs 300 300 (0%)
💬 Exclusive PKs 10 (3.3%) 10 (3.3%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 2 (out of 4 compared) ⚠️
💬 Total differing rows 290 / 290 (100%) ⚠️
💬 Total differing values 50% ⚠️
View diff details →


Diffs of downstream tables: ⚠️ - 2
INTEGRATION.BEERS.PROMO_DELIVERIES
main expand-IBU-categorization
💬 Total rows 180 180 (0%)
Schema diff
💬 Total columns 3 3
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (customer_id)
💬 Distinct PKs 180 180 (0%)
💬 Exclusive PKs 180 (100%) 180 (100%) ⚠️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 0 (out of 2 compared) ✔️
💬 Total differing rows 0 / 0 (-/-) ✔️
💬 Total differing values -/- ✔️
View diff details →

INTEGRATION.BEERS.BEERS_WITH_BREWERIES
main expand-IBU-categorization
💬 Total rows 2,410 2,410 (0%)
Schema diff
💬 Total columns 12 12
💬 Mismatched columns 0 0 (0 reorders, 0 type changes) ✔️
Primary keys diff (brewery_id, beer_id, beer_name)
💬 Distinct PKs 2,410 2,410 (0%)
💬 Exclusive PKs 0 (0%) 0 (0%) ✔️
💬 Null PKs 0 (0%) 0 (0%) ✔️
💬 Duplicate PKs 0 (0%) 0 (0%) ✔️
Values diff
💬 Differing columns 1 (out of 9 compared) ⚠️
💬 Total differing rows 671 / 2,410 (28%) ⚠️
💬 Total differing values 3.1% ⚠️
View diff details →


datafold[bot]
datafold bot reviewed Jul 25, 2022
View reviewed changes
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mode downstream: ✔️ - 0
Hightouch downstream: ⚠️ - 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datafold datafold[bot] datafold[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williebsweet @vvkh @sklinov