Merge pull request #232 from datafold/fix_pip_extras

Fix for pip extras (e.g. pip install data-diff[snowflake])
datafold · Sep 13, 2022 · 15f897e · 15f897e
2 parents 77ce613 + 933af8c
commit 15f897e
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 37 deletions.
diff --git a/data_diff/databases/databricks.py b/data_diff/databases/databricks.py
@@ -4,7 +4,7 @@
 from .base import MD5_HEXDIGITS, CHECKSUM_HEXDIGITS, Database, import_helper, _query_conn, parse_table_name
 
 
-@import_helper("databricks")
+@import_helper(text="You can install it using 'pip install databricks-sql-connector'")
 def import_databricks():
     import databricks.sql
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -29,6 +29,13 @@ dsnparse = "*"
 click = "^8.1"
 rich = "*"
 toml = "^0.10.2"
+mysql-connector-python = {version="*", optional=true}
+psycopg2 = {version="*", optional=true}
+snowflake-connector-python = {version="^2.7.2", optional=true}
+cryptography = {version="*", optional=true}
+trino = {version="^0.314.0", optional=true}
+presto-python-client = {version="*", optional=true}
+clickhouse-driver = {version="*", optional=true}
 
 [tool.poetry.dev-dependencies]
 parameterized = "*"
@@ -52,7 +59,7 @@ postgresql = ["psycopg2"]
 snowflake = ["snowflake-connector-python", "cryptography"]
 presto = ["presto-python-client"]
 oracle = ["cx_Oracle"]
-databricks = ["databricks-sql-connector"]
+# databricks = ["databricks-sql-connector"]
 trino = ["trino"]
 clickhouse = ["clickhouse-driver"]
 vertica = ["vertica-python"]