Merge pull request #863: [proxima-direct-core] O2-Czech-Republic#220 …

…remove Serializable from LogObserver
datadrivencz · Jan 4, 2024 · 0ab2010 · 0ab2010
2 parents d8ada16 + 2a70230
commit 0ab2010
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/direct/core/src/main/java/cz/o2/proxima/direct/core/LogObserver.java b/direct/core/src/main/java/cz/o2/proxima/direct/core/LogObserver.java
@@ -24,8 +24,7 @@
 /** Base interface for bulk and online observers. */
 @Stable
 public interface LogObserver<
-        OffsetT extends Serializable, ContextT extends LogObserver.OnNextContext<OffsetT>>
-    extends Serializable {
+    OffsetT extends Serializable, ContextT extends LogObserver.OnNextContext<OffsetT>> {
 
   /** Context passed to {@link #onNext}. */
   @Stable

diff --git a/flink/core/src/main/java/cz/o2/proxima/flink/core/AbstractSourceLogObserver.java b/flink/core/src/main/java/cz/o2/proxima/flink/core/AbstractSourceLogObserver.java
@@ -32,11 +32,8 @@
 /**
  * Log observer that writes consumed elements to {@link SourceFunction.SourceContext}.
  *
- * @see <a href="https://github.com/O2-Czech-Republic/proxima-platform/issues/220">PROXIMA-220</a>
- *     to explain {@code java:S1948} suppression.
  * @param <OutputT> Type of extracted element.
  */
-@SuppressWarnings("java:S1948")
 abstract class AbstractSourceLogObserver<
         OffsetT extends Serializable, ContextT extends LogObserver.OnNextContext<OffsetT>, OutputT>
     implements LogObserver<OffsetT, ContextT> {