Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious check for macro in MoPub ExchangeConnector #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix spurious check for macro in MoPub ExchangeConnector #18

wants to merge 2 commits into from

Conversation

jsulmont
Copy link

Please merge ASAP --

@mikebd
Copy link

mikebd commented Apr 17, 2014

MoPub does not support encryption, so it is not expecting ${AUCTION_PRICE:BF}.

We should check for ${AUCTION_PRICE} in the win notification nurl. That is required to pass the MoPub sandbox integration testing. ${AUCTION_PRICE} may also be provided in adm but MoPub considers nurl as authoritative and will not be satisfied by the presence of ${AUCTION_PRICE} in adm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsulmont @mikebd