Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi lines support #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

olivierHa
Copy link

Here is a patch to support multi-lines returned by graphite (and with a custom status message).
You can now use this plugin to check multiple values like :

./check_graphite.py -u 'http://graphite/rend?targer=carbon.agents.*.cache.queues" -w 500 -c 1000 -s "Carbon queue"

Olivier

@nicolaskruchten
Copy link
Contributor

Salut Olivier,

Thank you for your pull-request! Unfortunately, I find myself in a tough spot, as I cannot test it effectively... We no longer use check_graphite in our company, and I'm not that comfortable accepting pull-requests that I haven't run myself.

I would be happy to add a section of "useful forks" to the ReadMe file and link to your repo from there, so that people can clone yours if they want this feature, would that work for you?

Cheers,
Nicolas

@olivierHa
Copy link
Author

Salut :)

Indeed, I understand that if you can't test it, it is hard to accept Pull
Requests.
Let's go for a "useful forks link" in Readme then.
And when you will be able to test it, just merge it and suppress the link :)

Just by curiosity, you are no longer using Graphite or just the graphite
check ?

Regards

Olivier

2013/9/20 Nicolas Kruchten [email protected]

Salut Olivier,

Thank you for your pull-request! Unfortunately, I find myself in a tough
spot, as I cannot test it effectively... We no longer use check_graphite in
our company, and I'm not that comfortable accepting pull-requests that I
haven't run myself.

I would be happy to add a section of "useful forks" to the ReadMe file and
link to your repo from there, so that people can clone yours if they want
this feature, would that work for you?

Cheers,
Nicolas


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-24812243
.

@nicolaskruchten
Copy link
Contributor

Hi again,

I've added the link to your repo, and you can leave the pull request open
if you like to make it even easier to find.

We still very much use Graphite, but we have stopped using Nagios in favour
of Zabbix, so this particular script is no longer useful to us.

Cheers,
Nicolas

On Fri, Sep 20, 2013 at 10:20 AM, Olivier H [email protected]:

Salut :)

Indeed, I understand that if you can't test it, it is hard to accept Pull
Requests.
Let's go for a "useful forks link" in Readme then.
And when you will be able to test it, just merge it and suppress the link
:)

Just by curiosity, you are no longer using Graphite or just the graphite
check ?

Regards

Olivier

2013/9/20 Nicolas Kruchten [email protected]

Salut Olivier,

Thank you for your pull-request! Unfortunately, I find myself in a tough
spot, as I cannot test it effectively... We no longer use check_graphite
in
our company, and I'm not that comfortable accepting pull-requests that I
haven't run myself.

I would be happy to add a section of "useful forks" to the ReadMe file
and
link to your repo from there, so that people can clone yours if they
want
this feature, would that work for you?

Cheers,
Nicolas


Reply to this email directly or view it on GitHub<
https://github.com/datacratic/check_graphite/pull/13#issuecomment-24812243>

.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-24813566
.

Nicolas Kruchten, Eng | Head of Product Engineering at Datacratic |
http://datacratic.com/

Joerg and others added 12 commits October 31, 2013 11:12
Error when graphite returns only one value
also remove trainling whitespaces
... which is an equally or even more popular way to install Python
modules
it's easier to read in an editor with
shorter lines
at least on my system, if not given, then NagAnaconda will error out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants