-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added log_util.py for creating structured logs for log-based metric. #1209
Added log_util.py for creating structured logs for log-based metric. #1209
Conversation
74a4611
to
d908d3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rohit.
As we add more metrics for logging, please add some guidelines into util/log_util.py for
- what to add a new property:value as a metric:label vs what to add to message
such as it's impact to dashboards and monitoring configs. - can metric_labels have values as int, string, lists, etc
- is there a way to get aggregations in the monitoring dashboard (sum of log messages of a certain type+label), something like a Counter metric.
Thanks Ajai for the review. Addressed following review comments. Please review.
Added some guidelines on creating log-based metrics.
Yes, counter metrics are supported. Added a note that metric labels might not be required in counter metric. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rohit!
No description provided.