-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #148 - add a basic github release workflow. #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You might get problems with the slack notification, I think this job we use is out of date and I've ended up disabling for now until we look at a replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I would argue that there is a place for both testing on PR and testing on explicit workflow dispatch but given a choice PR is more important.
Purpose
To use github actions for our workflows instead of Travis-CI.
Additional work here. Ruby must be updated.
closes: issue #148
Approach
Used lupo as a template.
Turned off rubocop for now. I will add a ticket for using it in the workflows. It has never been run on sashimi before. I did a test run and there were over 1000 issues, hundreds of which cannot be fixed automatically. Those that were fixed automatically broke the testing. (Added issue #150 )
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: