Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DEPRECATION WARNING: ActiveModel::Errors#values is deprecated #992

Closed
wants to merge 1 commit into from
Closed

Fix DEPRECATION WARNING: ActiveModel::Errors#values is deprecated #992

wants to merge 1 commit into from

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Aug 3, 2023

Purpose

Fix the deprication warning.

closes: #datacite/datacite/issues/991

Approach

The original deprication warning included the fix. This just implemented it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads marked this pull request as draft August 3, 2023 18:46
@jrhoads jrhoads closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrhoads