Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove realtime indexing from TransferJob #1232

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

digitaldogsbody
Copy link
Member

Purpose

The TransferJob used to move all DOIs from one client to another was causing errors because it couldn't find the ElasticSearch client for some reason, and was therefore getting stuck in a loop and repeatedly retrying the job, causing the queues and the workers to back up and get stuck in an infinite loop.

Since the DOI is updated (client_id/datacenter change) it triggers the indexable concern and goes onto the queue to be indexed anyway, and we previously decided that with our current better queue management and autoscaling that the real-time indexing is no longer critical (c.f #1147), the simple fix is just to remove the real-time indexing functionality from this job.

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@digitaldogsbody digitaldogsbody requested a review from a team August 28, 2024 12:15
@digitaldogsbody digitaldogsbody merged commit ad428b9 into master Aug 28, 2024
13 checks passed
@digitaldogsbody digitaldogsbody deleted the fix-transferjob branch August 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants