Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serializer permissions #1227

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

richardhallett
Copy link
Contributor

Purpose

Don't return contacts on serialiser based on permissions.

closes: #1226

Approach

Check abilities before serialising.

Open Questions and Pre-Merge TODOs

N/A

Learning

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Test returns empty
read_contact is checked to not return relations/includes if not set
@richardhallett richardhallett requested review from codycooperross and a team August 12, 2024 07:58
@richardhallett richardhallett merged commit b158ab1 into master Aug 12, 2024
13 checks passed
@richardhallett richardhallett deleted the fix_serializer_permissions branch August 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure provider controller respects serializer rules when using include
2 participants