Rework gbif cleanup #1220
Merged
Rework gbif cleanup #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| event.destroy! if event.present? | ||
| # delete event records from mysql | ||
| sql = ActiveRecord::Base.sanitize_sql_array(["DELETE FROM events WHERE id IN (?)", ids]) | ||
| ActiveRecord::Base.connection.execute(sql) |
There was a problem hiding this comment.
When we delete the events using raw query, we are skipping the after_commit on: [:destroy] callback.
There was a problem hiding this comment.
@ashwinisukale yes this is by design as I will be using the bulk api to delete the documents in the events index.
|
|
||
| response = Event.query(query, filter.merge(page: { size: 1, cursor: [] })) | ||
|
|
||
| if response.size.positive? |
There was a problem hiding this comment.
we should verify if response.present? && response.respond_to?(:size) && response.size.positive? response present, incase of an error
| while response.size.positive? && delete_count < max_delete_count | ||
| response = Event.query(query, filter.merge(page: { size: size, cursor: cursor })) | ||
|
|
||
| break unless response.size.positive? |
There was a problem hiding this comment.
we can make little readable by checking it like this break if response.size.zero?
ashwinisukale
approved these changes
Jul 26, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: